Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayAdapter renders value twice #70

Closed
thijswiersema opened this issue Mar 1, 2019 · 4 comments
Closed

ArrayAdapter renders value twice #70

thijswiersema opened this issue Mar 1, 2019 · 4 comments

Comments

@thijswiersema
Copy link

I was just trying out the bundle, seems promising. But I encountered a little bug on my first test setup.

The column ArrayAdapter is transforming and rendering the value twice. It appears to happen in the processRow function here

protected function processRow(DataTableState $state, array $result, array $map, string $search)

Seems to me the call on L101 is unnecessary.

@shades684
Copy link
Contributor

You're right, but as stated in issue #7 the ArrayAdapter is far from completed.

@ceininger
Copy link

ceininger commented May 13, 2019

Hello @curry684 is it possible to have a new release with this fix inclued. I'm facing a problem with DateTimeColumn and nullValue fallback getting transformed twice (and then fail because the 2nd time, $value is a string).

Thanks

@curry684
Copy link
Member

Fair enough https://github.com/omines/datatables-bundle/releases/tag/0.3.0

@ceininger
Copy link

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants