Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Keep the ABC key in the same place for each keyboard-type in passphrase entry. #48

Open
rough-street opened this issue Feb 20, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@rough-street
Copy link

Something I find awkward with Krux is passphrase entry containing symbols, numbers etc.

As I loop through the different types of keyboard (lower-case, upper-case etc), the ABC button moves when it gets to the numeric keyboard (because it only has 4 columns rather than the 5 of the others). It means I hit the delete key by accident, meaning I have to loop through even more :-)

Any chance we could change the numeric keyboard to 5 columns? I'm happy to do the work if so.

@rough-street rough-street added the enhancement New feature or request label Feb 20, 2025
@odudex
Copy link
Owner

odudex commented Feb 20, 2025

You're not the first that got bothered by this. A fix would be welcome for sure!

Also, note that you can swipe to both sides to navigate between keypads

@rough-street
Copy link
Author

The swiping is a game changer - thanks for pointing that out.

I'll still take a look at the ABC key. Some ideas I have, in order of effort:

(a) simply move the ABC key into the bottom right for all of the keypads.
(b) keep the size of the keys fixed for all of the keypads (5 cols, 6 rows)
(c) make the "ABC", "<", "Esc" and "Go" keys fixed and separate from the rest of the keypad

Unless you're wildly against it, I'll probably go ahead and create a PR for (a) as a first attempt, and go from there as I think they're all incremental improvements.

@rough-street
Copy link
Author

Sorry, I realise now I created this issue in your fork rather than the main repo - doh! Anyway here's the PR in case you're interested :-D

selfcustody#506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants