fmt.assertf crashes on assertion fail #3000

guitarvydas · 2023-12-03T14:40:10Z

Context

fmt.assertf on assertion failure, crashes with bad trap

Operating System & Odin Version:

MacOS 13.6.1 (22G313)
odin version dev-2023-11:3c021f9c

Expected Behavior

My code should assert fail and print a message.

Current Behavior

Instead it crashes. Bad trap.

Failure Information (for bugs)

Steps to Reproduce

clone https://github.com/guitarvydas/0d.git
git checkout bug3
cd odin # ensure that pwd is ..../0d/odin
lldb agency.bin ../src/agency.drawio
run
bt

frame #5 calls fmt.assertf, then frame #0 crashes (len=... is suspicious, but looks OK in frame #1)

Failure Logs

contact me if more info required paultarvydas@gmail.com

guitarvydas · 2023-12-03T14:46:21Z

Failure Information (for bugs)

The code is in 0d/odin/registry0d.

Note that the fmt.printf on child_decl.name works, but the fmt.assertf crashes...

...
container_instantiator :: proc(reg: ^Component_Registry, owner : ^zd.Eh, name_prefix: string, decl: ir.Container_Decl) -> ^zd.Eh {

    ...
    {
        for child_decl in decl.children {
            fmt.printf ("  DEBUG: child_decl %v\n", child_decl)
            fmt.printf ("  DEBUG: child_decl.name %v\n", child_decl.name)
            ...
            fmt.assertf (ok, "\n*** Error: Can't find component %v\n", child_decl.name)
...

flysand7 · 2023-12-03T14:52:01Z

I'm trying to reproduce this on linux, and I seem to be getting an assertion when your code is trying to open a file in /tmp directory.

$ odin run agency -- ../src/agency.drawio 
/home/bumbread/temp/0d/odin/registry0d/registry.odin(47:5) Runtime assertion: read open error on /tmp/agency.drawio.json, err=2

This seems to be the relevant part, you seem to be opening the file but it's not created. Can you walk me through the process of how that temporary file is supposed to be created?

    fname := fmt.aprintf ("/tmp/%v.json", filepath.base (container_xml))
    read_fd, read_errnum := os.open (path=fname, flags=os.O_RDONLY)
    fmt.assertf (read_errnum == 0, "read open error on %v, err=%v\n", fname, read_errnum)

guitarvydas · 2023-12-03T20:15:47Z

I don't believe that that's the main issue. I did, however, forget that you might need to rebuild this and (obviously) did not provide all the files. The missing file is due to something else, the issue appears to be when I call fmt.assertf (...).

Here is what lldb shows me (on my mac). Basically, my code stops at Frame #5 and calls fmt.assertf (...). From there on up (Frames #4->#0), it's Odin runtime code. Maybe runtime.print_caller_location (...)???

Frame 4 looks OK, with a sensible string length of 17. Somewhere after that, the runtime code crashes. I notice that Frame #2 appears to have a biazarre string length of 4295443986.

If that doesn't suggest a fix, then I will continue culling my example code...


$ lldb agency.bin ../src/agency.drawio 
(lldb) target create "agency.bin"
Current executable set to '/Users/tarvydas/quicklisp/local-projects/0d/odin/agency.bin' (x86_64).
(lldb) settings set -- target.run-args  "../src/agency.drawio"
(lldb) run
Process 95492 launched: '/Users/tarvydas/quicklisp/local-projects/0d/odin/agency.bin' (x86_64)
DEBUG: main_container_name = main
DEBUG: diagram_source_file = ../src/agency.drawio
  DEBUG: child_decl Elem_Reference{name = "'Translate to Lithuanian'", id = 12}
  DEBUG: child_decl.name 'Translate to Lithuanian'
Process 95492 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_SYSCALL (code=4, subcode=0x1)
    frame #0: 0x000000010000fcca agency.bin`runtime._os_write(data=(data = "/Users/tarvydas/quicklisp/local-projects/0d/odin/registry0d/registry.odin", len = 4295448388)) at os_specific_darwin.odin:7:2
   4   	import "core:intrinsics"
   5   	
   6   	_os_write :: proc "contextless" (data: []byte) -> (int, _OS_Errno) {
-> 7   		ret := intrinsics.syscall(4, 1, uintptr(raw_data(data)), uintptr(len(data)))
   8   		if ret < 0 {
   9   			return 0, _OS_Errno(-ret)
   10  		}
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_SYSCALL (code=4, subcode=0x1)
  * frame #0: 0x000000010000fcca agency.bin`runtime._os_write(data=(data = "/Users/tarvydas/quicklisp/local-projects/0d/odin/registry0d/registry.odin", len = 4295448388)) at os_specific_darwin.odin:7:2
    frame #1: 0x000000010000f9e7 agency.bin`runtime.os_write(data=(data = "/Users/tarvydas/quicklisp/local-projects/0d/odin/registry0d/registry.odin", len = 59)) at os_specific.odin:6:2
    frame #2: 0x0000000100010d32 agency.bin`runtime.print_string(str=(data = "/Users/tarvydas/quicklisp/local-projects/0d/odin/registry0d/registry.odin", len = 4295443986)) at print.odin:126:7
    frame #3: 0x00000001000132ac agency.bin`runtime.print_caller_location(loc=runtime.Source_Code_Location @ 0x00007ff7bfefe350) at print.odin:227:2
    frame #4: 0x00000001000164b0 agency.bin`runtime.default_assertion_failure_proc(prefix=(data = "Runtime assertion", len = 140702053819344), message=(data = "\n*** Error: Can't find component 'Translate to Lithuanian'\n", len = 17), loc=runtime.Source_Code_Location @ 0x00007ff7bfefe3d0) at core.odin:668:4
    frame #5: 0x0000000100018622 agency.bin`fmt.assertf(condition=false, fmt=(data = "\n*** Error: Can't find component %v\n", len = 140702053819520), args=(data = "X\xeb\xef\xbf\xf7\U0000007f", len = 36), loc=runtime.Source_Code_Location @ 0x00007ff7bfefe480) at fmt.odin:265:3
    frame #6: 0x000000010003b119 agency.bin`registry0d.container_instantiator(reg=0x00007ff7bfeff1a8, owner=0x0000000000000000, name_prefix=(data = 0x0000000000000000, len = 140702053821648), decl=ir.Container_Decl @ 0x00007ff7bfefecd0) at registry.odin:115:13
    frame #7: 0x000000010003a6c2 agency.bin`registry0d.get_component_instance(reg=0x00007ff7bfeff1a8, name_prefix=(data = 0x0000000000000000, len = 140702053823216), name=(data = "main", len = 0), owner=0x0000000000000000) at registry.odin:90:22
    frame #8: 0x000000010001687e agency.bin`agency.run(r=0x00007ff7bfeff1a8, main_container_name=(data = "main", len = 140702053823216), diagram_source_file=(data = "../src/agency.drawio", len = 4), injectfn=(agency.bin`agency.start_function at main.odin:26)) at main.odin:47:5
    frame #9: 0x0000000100016303 agency.bin`agency.main at main.odin:20:5
    frame #10: 0x0000000100064f77 agency.bin`main(argc=2, argv=0x00007ff7bfeff620) at entry_unix.odin:53:4
    frame #11: 0x00007ff809bcd41f dyld`start + 1903
(lldb)

flysand7 · 2023-12-04T01:17:24Z

fmt.assertf(condition=false, fmt=(data = "\n*** Error: Can't find component %v\n", len = 140702053819520)

Well that looks sus. I think something about your call to the failing assert is busted

laytan · 2023-12-04T01:30:08Z

I think these massive lengths are just bad debug info which I encounter a lot. Does this also happen when you change the fmt.assertf() to a normal assert(ok) call?

flysand7 · 2023-12-04T01:38:21Z

Could it be that the syscall number is wrong? Though that would be weird I can't imagine anyone else not hitting that if that's the case, however the error message seems to suggest that it's the case for other people who've been getting a similar problem.

Also your screenshot says the stop reason is EXC_SYSCALL. I'm not familiar with macOS, but does that mean it just hits a syscall but isn't necessarily a crash? Or does that mean the syscall number is actually wrong?

laytan · 2023-12-04T02:04:44Z

You migh be right, it could require 0x2000004 as the syscall instead of just 4. This is some kind of class designation with the upper bits. It might be a requirement for x86_64 when most people are on arm nowadays which would explain why it hasn't come up.

@guitarvydas can you try changing core/runtime/os_specific_darwin.odin at line 7, swapping out the 4 with the hex above?

guitarvydas · 2023-12-04T03:46:48Z

Main.odin calls 2 functions. They are almost the same, except that

no_assertf_fail_fn explicitly tests ok and prints an error message using fmt.printf()
fail_fn calls fmt.assertf() to do the same testing, but crashes

This might be a MacOS issue...

On my Mac (Intel, MacOS Ventura 13.6.1), the second call crashes. As far as I can tell, the failure happens due to core:fmt (namely assertf).

$ make
make
rm -f bug3
odin build . -debug -o:none
ld: warning: no platform load command found in '/Users/tarvydas/quicklisp/local-projects/odin-bug3/odin-bug3.o', assuming: macOS
odin run .
ld: warning: no platform load command found in '/Users/tarvydas/quicklisp/local-projects/odin-bug3/odin-bug3.o', assuming: macOS
  DEBUG: name xyz
  DEBUG: ok=false
  DEBUG: len (name) 3

*** Error: Can't find component xyz
  DEBUG: name xyz
  DEBUG: ok=false
  DEBUG: len (name) 3
make: *** [bug3] Error 12
$

To duplicate:
clone https://github.com/guitarvydas/odin-bug3.git
make

(Maybe this works fine on Linux, but crashes on MacOS).

guitarvydas · 2023-12-04T03:51:33Z

It appears that the 0x2000004 change fixes this issue.

Error messages as expected, but no crash

$ make
make
rm -f bug3
odin build . -debug -o:none
ld: warning: no platform load command found in '/Users/tarvydas/quicklisp/local-projects/odin-bug3/odin-bug3.o', assuming: macOS
odin run .
ld: warning: no platform load command found in '/Users/tarvydas/quicklisp/local-projects/odin-bug3/odin-bug3.o', assuming: macOS
  DEBUG: name xyz
  DEBUG: ok=false
  DEBUG: len (name) 3

*** Error: Can't find component xyz
  DEBUG: name xyz
  DEBUG: ok=false
  DEBUG: len (name) 3
/Users/tarvydas/quicklisp/local-projects/odin-bug3/main.odin(9:5) Runtime assertion: 
*** Error: Can't find component xyz

make: *** [bug3] Error 4
$ ```

laytan · 2023-12-04T13:51:16Z

Nice, I will verify it works on arm too and create a PR to fix it for everyone

flysand7 · 2023-12-04T13:59:39Z

Congradulations, this is 3000'th issue that's been posted on this project and you won the prize of 1 million USD, which you can claim if you follow the following link:

claim your prize

EDIT: me realising that double underscore doesn't make underlined text in markdown. How do you do it?

laytan mentioned this issue Dec 4, 2023

fix write on x86_64 Darwin #3002

Merged

gingerBill closed this as completed in #3002 Dec 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fmt.assertf crashes on assertion fail #3000

fmt.assertf crashes on assertion fail #3000

guitarvydas commented Dec 3, 2023

guitarvydas commented Dec 3, 2023 •

edited

Loading

flysand7 commented Dec 3, 2023

guitarvydas commented Dec 3, 2023

flysand7 commented Dec 4, 2023

laytan commented Dec 4, 2023

flysand7 commented Dec 4, 2023

laytan commented Dec 4, 2023 •

edited

Loading

guitarvydas commented Dec 4, 2023

guitarvydas commented Dec 4, 2023 •

edited

Loading

laytan commented Dec 4, 2023

flysand7 commented Dec 4, 2023 •

edited

Loading

fmt.assertf crashes on assertion fail #3000

fmt.assertf crashes on assertion fail #3000

Comments

guitarvydas commented Dec 3, 2023

Context

Operating System & Odin Version:

Expected Behavior

Current Behavior

Failure Information (for bugs)

Steps to Reproduce

Failure Logs

guitarvydas commented Dec 3, 2023 • edited Loading

Failure Information (for bugs)

flysand7 commented Dec 3, 2023

guitarvydas commented Dec 3, 2023

flysand7 commented Dec 4, 2023

laytan commented Dec 4, 2023

flysand7 commented Dec 4, 2023

laytan commented Dec 4, 2023 • edited Loading

guitarvydas commented Dec 4, 2023

guitarvydas commented Dec 4, 2023 • edited Loading

laytan commented Dec 4, 2023

flysand7 commented Dec 4, 2023 • edited Loading

guitarvydas commented Dec 3, 2023 •

edited

Loading

laytan commented Dec 4, 2023 •

edited

Loading

guitarvydas commented Dec 4, 2023 •

edited

Loading

flysand7 commented Dec 4, 2023 •

edited

Loading