Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: A webhook typed PackageEvent with a nuget_metadata field throw an JsonException #460

Closed
1 task done
renardguill opened this issue Feb 29, 2024 · 1 comment · Fixed by #463
Closed
1 task done
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@renardguill
Copy link
Contributor

What happened?

A webhook typed PackageEvent with a nuget_metadata field throw an JsonException

The type of nuget_metadata field in Octokit.Webhooks is IDictionary<string, dynamic>?

public IDictionary<string, dynamic>? NugetMetadata { get; init; }

But in the GitHub documentation the type of nuget_metadata is array of objects or null
https://docs.github.com/en/webhooks/webhook-events-and-payloads#package

Below a reproducible test case on dotnetfiddle.com
https://dotnetfiddle.net/CeroqZ

Versions

Octokit.Webhooks v2.1.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@renardguill renardguill added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 29, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@renardguill renardguill changed the title [BUG]: A webhook typed **PackageEvent** with a **nuget_metadata** field throw an JsonException [BUG]: A webhook typed PackageEvent with a nuget_metadata field throw an JsonException Feb 29, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant