Use IsNumericType

manfred-brands · manfred-brands · commit 36b8b1d37ce7 · 2024-12-18T12:15:38.000+08:00
diff --git a/src/NUnitFramework/framework/Constraints/EqualNumericWithoutUsingConstraint.cs b/src/NUnitFramework/framework/Constraints/EqualNumericWithoutUsingConstraint.cs
@@ -127,7 +127,7 @@ public ConstraintResult ApplyTo(T actual)
             // In that case fall back to the default equality comparison.
             bool hasSucceeded;
 
-            if (Numerics.IsNumericType(actual))
+            if (Numerics.IsNumericType(typeof(T)))
             {
                 hasSucceeded = Numerics.AreEqual(_expected, actual, ref _tolerance);
             }
@@ -155,7 +155,7 @@ public override ConstraintResult ApplyTo<TActual>(TActual actual)
             {
                 hasSucceeded = false;
             }
-            else if (actual is T t && Numerics.IsNumericType(t))
+            else if (actual is T t && Numerics.IsNumericType(typeof(T)))
             {
                 hasSucceeded = Numerics.AreEqual(_expected, t, ref _tolerance);
             }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public ConstraintResult ApplyTo(T actual)`
`127`	`127`	`// In that case fall back to the default equality comparison.`
`128`	`128`	`bool hasSucceeded;`
`129`	`129`
`130`		`- if (Numerics.IsNumericType(actual))`
	`130`	`+ if (Numerics.IsNumericType(typeof(T)))`
`131`	`131`	`{`
`132`	`132`	`hasSucceeded = Numerics.AreEqual(_expected, actual, ref _tolerance);`
`133`	`133`	`}`
`@@ -155,7 +155,7 @@ public override ConstraintResult ApplyTo<TActual>(TActual actual)`
`155`	`155`	`{`
`156`	`156`	`hasSucceeded = false;`
`157`	`157`	`}`
`158`		`- else if (actual is T t && Numerics.IsNumericType(t))`
	`158`	`+ else if (actual is T t && Numerics.IsNumericType(typeof(T)))`
`159`	`159`	`{`
`160`	`160`	`hasSucceeded = Numerics.AreEqual(_expected, t, ref _tolerance);`
`161`	`161`	`}`