ir/netmap: Fix admitting of netmap candidates with duplicate attributes

Defect of 757b90e.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>

Author: cthulhu-rider

pkg/innerring/processors/netmap/nodevalidation/structure/calls.go

@@ -18,7 +18,9 @@ func (v *Validator) Verify(n netmap.NodeInfo) error {
 	n.IterateAttributes(func(key, _ string) {
 		if _, alreadyHave := attrM[key]; alreadyHave {
 			err = fmt.Errorf("repeating node attribute: '%s'", key)
+			return
 		}
+		attrM[key] = struct{}{}
 	})
 
 	return err

pkg/innerring/processors/netmap/nodevalidation/structure/calls_test.go

@@ -0,0 +1,23 @@
+package structure_test
+
+import (
+	"testing"
+
+	"github.com/nspcc-dev/neofs-node/pkg/innerring/processors/netmap/nodevalidation/structure"
+	"github.com/nspcc-dev/neofs-sdk-go/netmap"
+	"github.com/stretchr/testify/require"
+)
+
+func TestValidator_Verify(t *testing.T) {
+	v := structure.New()
+	t.Run("duplicated attributes", func(t *testing.T) {
+		var n netmap.NodeInfo
+		n.SetAttributes([][2]string{
+			{"key1", "val1"},
+			{"key2", "val2"},
+			{"key1", "val3"},
+			{"key2", "val4"},
+		})
+		require.EqualError(t, v.Verify(n), "repeating node attribute: 'key2'")
+	})
+}