fix: throw 403 for forbidden major/minor versions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: @claudiahdz Co-authored-by: @emyl3 Co-authored-by: @rrconey
darcyclarke
approved these changes
Aug 27, 2019
|
Landed and published as v3.0.1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
This PR fixes a bug where
targetwas not being resolved correctly for major/minor versions. Since elements are removed from theversionsobject of the packument by the proxy the algorithm had trouble finding a satisfying version to resolve the target to. This led to anulltarget which was interpreted as a not found. Adding an extra check on thepolicyRestrictions.versionsobject allows us to correctly resolve the target and later check if it's a forbidden target or not.Ex.
npm install lodash@1🔗 References
Card: https://npmjsinc.leankit.com/card/891629888
🔍 Testing
Automated testing
✅ This change has unit test coverage