Skip to content

Commit f4133b5

Browse files
committed
fix(semver): use semver.clean() instead
1 parent 274e4c9 commit f4133b5

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

index.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@ const semver = require('semver')
66
module.exports = pickManifest
77
function pickManifest (packument, wanted, opts) {
88
opts = opts || {}
9-
wanted = wanted.trim()
109
const spec = npa.resolve(packument.name, wanted)
1110
const type = spec.type
11+
if (type === 'version' || type === 'range') {
12+
wanted = semver.clean(wanted) || wanted
13+
}
1214
const distTags = packument['dist-tags'] || {}
1315
const versions = Object.keys(packument.versions || {}).filter(v => semver.valid(v))
1416
let err

test/index.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,10 @@ test('basic mathematical range selection', t => {
4141
'2.0.0': { version: '2.0.0' }
4242
}
4343
}
44-
const manifest = pickManifest(metadata, '>=1.0.0 <2')
45-
t.equal(manifest.version, '1.0.2', 'picked the right manifest using mathematical range')
44+
const manifest1 = pickManifest(metadata, '>=1.0.0 <2')
45+
t.equal(manifest1.version, '1.0.2', 'picked the right manifest using mathematical range')
46+
const manifest2 = pickManifest(metadata, '=1.0.0')
47+
t.equal(manifest2.version, '1.0.0', 'picked the right manifest using mathematical range')
4648
t.done()
4749
})
4850

0 commit comments

Comments
 (0)