From 5646be80f6906de8148d26e3816920d360b08297 Mon Sep 17 00:00:00 2001 From: Patrick Zheng Date: Wed, 3 Jan 2024 16:36:01 +0800 Subject: [PATCH 1/2] fixed SetHTTPDebugLog Signed-off-by: Patrick Zheng --- internal/trace/transport.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/trace/transport.go b/internal/trace/transport.go index 86700c692..588b24965 100644 --- a/internal/trace/transport.go +++ b/internal/trace/transport.go @@ -88,14 +88,14 @@ func logHeader(header http.Header, e log.Logger) { // SetHTTPDebugLog sets up http debug log with logrus.Logger func SetHTTPDebugLog(ctx context.Context, authClient *auth.Client) { - if logrusLog, ok := log.GetLogger(ctx).(*logrus.Logger); ok && logrusLog.Level != logrus.DebugLevel { + if logrusLog, ok := log.GetLogger(ctx).(*logrus.Logger); !ok || logrusLog.Level != logrus.DebugLevel { return } if authClient.Client == nil { - authClient.Client = http.DefaultClient + authClient.Client = &http.Client{} } if authClient.Client.Transport == nil { - authClient.Client.Transport = http.DefaultTransport + authClient.Client.Transport = http.DefaultTransport.(*http.Transport).Clone() } authClient.Client.Transport = NewTransport(authClient.Client.Transport) } From 44f7c0a6e24fc2a3e59e62de2fd14bf2bf4a9107 Mon Sep 17 00:00:00 2001 From: Patrick Zheng Date: Wed, 3 Jan 2024 17:26:08 +0800 Subject: [PATCH 2/2] updated per code review Signed-off-by: Patrick Zheng --- internal/trace/transport.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/trace/transport.go b/internal/trace/transport.go index 588b24965..a83ebda19 100644 --- a/internal/trace/transport.go +++ b/internal/trace/transport.go @@ -95,7 +95,7 @@ func SetHTTPDebugLog(ctx context.Context, authClient *auth.Client) { authClient.Client = &http.Client{} } if authClient.Client.Transport == nil { - authClient.Client.Transport = http.DefaultTransport.(*http.Transport).Clone() + authClient.Client.Transport = http.DefaultTransport } authClient.Client.Transport = NewTransport(authClient.Client.Transport) }