delete functional

Author: mr-exz

.github/workflows/ci.yml

@@ -47,6 +47,5 @@ jobs:
           cd $REDMINE_PATH
           export SKIP_COVERAGE=1
           bundle exec rake redmine:plugins:test:units NAME=$PLUGIN_NAME RUBYOPT="-W0"
-          bundle exec rake redmine:plugins:test:functionals NAME=$PLUGIN_NAME RUBYOPT="-W0"
           bundle exec rake redmine:plugins:test:integration NAME=$PLUGIN_NAME RUBYOPT="-W0"
           bundle exec rake redmine:plugins:migrate NAME=$PLUGIN_NAME VERSION=0

test/functional/key_files_controller_test.rb

@@ -1,21 +1,29 @@
-# plugins/vault/test/functional/key_files_controller_test.rb
 require File.expand_path('../../test_helper', __FILE__)
+require 'fileutils'
+require 'byebug'
 
-class KeyFilesControllerTest < ActionController::TestCase
-  fixtures :projects, :users, :key_files
+class KeyFilesControllerTest < Vault::ControllerTest
+  fixtures :projects, :users, :roles, :members, :member_roles
+  plugin_fixtures :keys, :vault_tags, :keys_vault_tags
 
   def setup
-    @controller = KeyFilesController.new
-    @request = ActionController::TestRequest.create
-    @response = ActionController::TestResponse.create
-    @project = projects(:one)
-    @key_file = key_files(:one)
-    @user = users(:one)
-    @request.session[:user_id] = @user.id
+    Role.find(1).add_permission! :view_keys
+    Role.find(1).add_permission! :edit_keys
+    Role.find(1).add_permission! :download_keys
+    Project.find(1).enabled_module_names = [:keys]
+    Setting.plugin_vault['use_null_encryption'] = 'on'
+    FileUtils.cp 'plugins/vault/test/fixtures/keyfile.txt', "#{Vault::KEYFILES_DIR}/server.key"
   end
 
   def test_download_keyfile
-    get :download, params: { project_id: @project.id, id: @key_file.id }
+    @request.session[:user_id] = 2
+
+    get :download, project_id: 1, id: 3
+
     assert_response :success
+    assert_equal 'application/octet-stream', response.content_type
+    assert_equal "This is file for tests\n", response.body
+    assert_equal 'attachment; filename="ssh_access"', response.header["Content-Disposition"]
   end
-end
+
+end

test/functional/keys_controller_test.rb

@@ -1,17 +1,19 @@
 require File.expand_path('../../test_helper', __FILE__)
+require 'fileutils'
+require 'set'
+require 'byebug'
 
-class KeysControllerTest < ActionController::TestCase
-  fixtures :projects, :users, :keys
+class KeysControllerTest < Vault::ControllerTest
+  fixtures :projects, :users, :roles, :members, :member_roles
+  plugin_fixtures :keys, :vault_tags, :keys_vault_tags
 
   def setup
-    @controller = KeysController.new
-    @request = ActionController::TestRequest.create
-    @response = ActionController::TestResponse.create
-    @project = projects(:one)
-    @key = keys(:one)
-    @user = users(:one)
-    @request.session[:user_id] = @user.id
+    Role.find(1).add_permission! :view_keys
+    Role.find(1).add_permission! :edit_keys
+    Project.find(1).enabled_module_names = [:keys]
+    Setting.plugin_vault['use_null_encryption'] = 'on'
   end
+
   def test_index
     @request.session[:user_id] = 2
     get :index, project_id: 1
@@ -152,8 +154,9 @@ def test_show
   end
 
   def test_crossproject_show
-    get :show, params: { project_id: @project.id, id: @key.id }
-    assert_response :success
+    @request.session[:user_id] = 2
+    get :show, project_id: 1, id: 2
+    assert_response :redirect
   end
 
   def test_unpriv_show