Skip to content

Commit 425bcd0

Browse files
committed
fix: Fixed the last failing test for EnvEnsure().
1 parent 5c75b92 commit 425bcd0

File tree

1 file changed

+29
-13
lines changed

1 file changed

+29
-13
lines changed

corefuncprovider/env_ensure_data_source_test.go

+29-13
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package corefuncprovider
33
import (
44
"fmt"
55
"os"
6+
"regexp"
67
"strings"
78
"testing"
89

@@ -23,24 +24,39 @@ func TestAccEnvEnsureDataSource(t *testing.T) {
2324

2425
_ = os.Setenv(tc.EnvVarName, tc.SetValue)
2526

26-
resource.Test(t, resource.TestCase{
27-
ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
28-
Steps: []resource.TestStep{
29-
{
30-
Config: providerConfig + `
27+
// We expect the error to be nil.
28+
if tc.ExpectedErr == nil {
29+
resource.Test(t, resource.TestCase{
30+
ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
31+
Steps: []resource.TestStep{
32+
{
33+
Config: providerConfig + `
3134
data "corefunc_env_ensure" "env" {
3235
name = "` + tc.EnvVarName + `"
3336
}
3437
`,
35-
Check: resource.ComposeAggregateTestCheckFunc(
36-
resource.TestCheckResourceAttr(
37-
"data.corefunc_env_ensure.env",
38-
"value",
39-
tc.SetValue,
38+
Check: resource.ComposeAggregateTestCheckFunc(
39+
resource.TestCheckResourceAttr("data.corefunc_env_ensure.env", "value", tc.SetValue),
4040
),
41-
),
41+
},
4242
},
43-
},
44-
})
43+
})
44+
} else {
45+
// We DO expect an error.
46+
// https://developer.hashicorp.com/terraform/plugin/testing/testing-patterns
47+
resource.Test(t, resource.TestCase{
48+
ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
49+
Steps: []resource.TestStep{
50+
{
51+
Config: providerConfig + `
52+
data "corefunc_env_ensure" "env" {
53+
name = "` + tc.EnvVarName + `"
54+
}
55+
`,
56+
ExpectError: regexp.MustCompile("environment variable (\\w+) is not defined"),
57+
},
58+
},
59+
})
60+
}
4561
}
4662
}

0 commit comments

Comments
 (0)