Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate merkle module in stdlib and create external library #4858

Closed
Tracked by #6193
, #1258
...
TomAFrench opened this issue Apr 20, 2024 · 1 comment · Fixed by #7582
Closed
Tracked by #6193
, #1258
...

Deprecate merkle module in stdlib and create external library #4858

TomAFrench opened this issue Apr 20, 2024 · 1 comment · Fixed by #7582
Labels
stdlib Standard library shipped with Noir tooling

Comments

@TomAFrench
Copy link
Member

We don't want the functionality in the merkle module within the stdlib to be part of it at 1.0. We should then deprecate this module and create a new library from which users can install it.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 20, 2024
@TomAFrench TomAFrench added the stdlib Standard library shipped with Noir tooling label Apr 21, 2024
This was referenced Apr 21, 2024
Open
Closed
@TomAFrench TomAFrench mentioned this issue Oct 1, 2024
Closed
@TomAFrench
Copy link
Member Author

Closed by #7413, we're not creating an external library due to the simplicity of the code being such that users can just vendor the function.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 18, 2025
@TomAFrench TomAFrench mentioned this issue Mar 4, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Standard library shipped with Noir tooling
Projects
Noir
Archived in project
Milestone
No milestone
1 participant
@TomAFrench