fix: using default parameter to avoid runtime error #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick fix to avoid the following error when no action is passed in constructor: TypeError: Cannot read property 'name' of undefined
lance
reviewed
Jan 3, 2021
There was a problem hiding this comment.
The action parameter should be a function not object. However, personally I don't think a default action should exist as it makes no sense. In my opinion, a TypeError should still be thrown, but with an error message describing the problem. For example, "No action provided. Cannot construct a CircuitBreaker without an invokable action."
makes a lot of sense to me looking this way now. I'm going to create an issue for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to avoid the following error when no action is passed in the constructor:
TypeError: Cannot read property 'name' of undefined
Related to #514