Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build on windows10 due browserify limitations #112

Merged
merged 1 commit into from
Nov 27, 2017
Merged

fix: build on windows10 due browserify limitations #112

merged 1 commit into from
Nov 27, 2017

Conversation

helio-frota
Copy link
Member

@helio-frota helio-frota commented Nov 23, 2017 •
edited
Loading

Connects to #109

@coveralls
Copy link

coveralls commented Nov 23, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 99.396% when pulling dee8d93 on helio-frota:pr into 368f116 on bucharest-gold:master.

@helio-frota helio-frota requested a review from lance November 27, 2017 14:41
@lance
Copy link
Member

lance commented Nov 27, 2017

@helio-frota thanks for this fix. I think we should consider removing browserfy in the long run.

@lance lance merged commit dee4a9a into nodeshift:master Nov 27, 2017
@helio-frota helio-frota deleted the pr branch November 27, 2017 15:04
@helio-frota helio-frota self-assigned this Dec 21, 2020
@lholmquist lholmquist mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance Awaiting requested review from lance

Assignees

@helio-frota helio-frota

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helio-frota @coveralls @lance