fix: don't send keep-alive if we want reset (#1846)

ronag · web-flow · commit f376a12a77cc · 2023-01-02T13:22:49.000Z
diff --git a/lib/client.js b/lib/client.js
@@ -1395,7 +1395,7 @@ function write (client, request) {
 
   if (upgrade) {
     header += `connection: upgrade\r\nupgrade: ${upgrade}\r\n`
-  } else if (client[kPipelining]) {
+  } else if (client[kPipelining] && !socket[kReset]) {
     header += 'connection: keep-alive\r\n'
   } else {
     header += 'connection: close\r\n'
diff --git a/test/proxy-agent.js b/test/proxy-agent.js
@@ -323,7 +323,7 @@ test('ProxyAgent correctly sends headers when using fetch - #1355, #1623', { ski
 
   const expectedProxyHeaders = {
     host: `localhost:${proxy.address().port}`,
-    connection: 'keep-alive'
+    connection: 'close'
   }
 
   proxy.on('connect', (req, res) => {

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ test('ProxyAgent correctly sends headers when using fetch - #1355, #1623', { ski`
`323`	`323`
`324`	`324`	`const expectedProxyHeaders = {`
`325`	`325`	host: `localhost:${proxy.address().port}`,
`326`		`- connection: 'keep-alive'`
	`326`	`+ connection: 'close'`
`327`	`327`	`}`
`328`	`328`
`329`	`329`	`proxy.on('connect', (req, res) => {`