This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a22839f
to
7e1670b
Compare
trivikr
reviewed
Aug 22, 2019
trivikr
approved these changes
Aug 22, 2019
Hmm... not working on linux... |
heh... doh, forgot about the cctests :-) |
7e1670b
to
e2c14ba
Compare
e2c14ba
to
937827b
Compare
@nodejs/quic ... be aware, I'm going to land this now. Once it lands, you'll need to use |
jasnell
added a commit
that referenced
this pull request
Aug 22, 2019
PR-URL: #83 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
added a commit
that referenced
this pull request
Aug 22, 2019
PR-URL: #83 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
landed |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #55
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes