-
Notifications
You must be signed in to change notification settings - Fork 49
For new contributors: here's how to build Node.js with QUIC enabled #183
Comments
This will be great, but in my case, I'm still facing issues building node in local machine.
Thanks |
@OmerHerera Can you create a new issue sharing the errors you're getting while building node in your local machine? That way it'll be easy for us to debug. Here's an example issue I'd created when coverage was failing on my local machine #151 |
Can you create a new issue with this suggestion, so that we can discuss it in detail?
We discussed in #175 and decided to create this pinned issue instead which extends detailed documentation from Node.js core main repo. Let us know what problems you're facing in a separate GitHub issue. |
Thanks, I just open a new issue #184 |
I didnt want to start a new issue as I think my problem fits in this issue. Im very interessted in quic but also pretty new to quic and Im trying to build node with quic enabled. As far as I understand, your instructions are for building node with quic on a computer with macOS, or am i wrong? What are the steps for a windows computer? I have followed the BUILDING.md instructions for windows and I have cloned https://github.com/nodejs/quic instead of https://github.com/nodejs/node. I can run my regular node applications without problems but when I try to run something like trivikr's example from https://github.com/trivikr/node-http-servers.git I always get the error message: No such module: quic. So i guess i missed something on the way to build node with quic correctly, but I have no clue what. I hope somebody can help me to resolve my problem. Thanks. Greetings, |
@AttilaDjerdj Can you double check that when you specified the I don't have a windows machine to test on but it should be possible to specify this option like this: .\vcbuild.bat experimental-quic |
Thank you @AttilaDjerdj for trying out quic As @danbev pointed out, can you try if the following command works on your Windows machine? .\vcbuild experimental-quic |
It works, my error message is fixed. This is great, thanks a lot guys : ) |
FYI to anyone building on ARM it's not working (#39). |
Hi, Thanks in advance! Greetings |
@alexpresss Can you show us how you are using quic. It might be the case that the function const quic = require('net');
console.log(quic); $ ./node quic.js
{
_createServerHandle: [Function: createServerHandle],
_normalizeArgs: [Function: normalizeArgs],
_setSimultaneousAccepts: [Function: _setSimultaneousAccepts],
connect: [Function: connect],
createConnection: [Function: connect],
createServer: [Function: createServer],
isIP: [Function: isIP],
isIPv4: [Function: isIPv4],
isIPv6: [Function: isIPv6],
Server: [Function: Server],
Socket: [Function: Socket],
Stream: [Function: Socket],
createQuicSocket: [Function: createQuicSocket]
} If node was built with |
The way QUIC is exposed has changed fairly recently to allow it to land in nodejs/node master as a semver-minor. Instead of using const { createQuicSocket } = require('net') |
I’m new to quic protocol, can anyone help me with the steps of running this in VS code because I’m not being able to download this code. Regards. |
@trivikr can you please help that why the repository is unavailable? |
The instructions are similar to one given in CONTRIBUTING.md or BUILDING.md in Node.js core repo, but with the following changes:
--experimental-quic
while running./configure
For example:
./configure
, you've to run./configure --experimental-quic
insteadExample commands to run coverage:
$ .\vcbuild experimental-quic coverage
EDITs:
2019-11-11: Added instructions for Windows as pointed out in For new contributors: here's how to build Node.js with QUIC enabled #183 (comment)
2020-02-17 - Due to some as yet unknown bug during build using Visual Studio Build Tools 2017, it is necessary to build on Windows using Visual Studio Build Tools 2019. See WTF? #344
The text was updated successfully, but these errors were encountered: