test: skip quic tests if no quic

PR-URL: #83 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nodejs · Aug 22, 2019 · 262c16b · 262c16b
1 parent bc02d74
commit 262c16b
Show file tree

Hide file tree

Showing 12 changed files with 25 additions and 22 deletions.
diff --git a/test/common/index.js b/test/common/index.js
@@ -46,6 +46,7 @@ if (isMainThread)
 const noop = () => {};
 
 const hasCrypto = Boolean(process.versions.openssl);
+const hasQuic = Boolean(process.versions.ngtcp2);
 
 // Check for flags. Skip this for workers (both, the `cluster` module and
 // `worker_threads`) and child processes.
@@ -756,6 +757,7 @@ module.exports = {
   getTTYfd,
   hasIntl,
   hasCrypto,
+  hasQuic,
   hasIPv6,
   hasMultiLocalhost,
   isAIX,

diff --git a/test/parallel/test-quic-binding.js b/test/parallel/test-quic-binding.js
@@ -2,8 +2,9 @@
 'use strict';
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
+
 const assert = require('assert');
 const { internalBinding } = require('internal/test/binding');
 

diff --git a/test/parallel/test-quic-client-server.js b/test/parallel/test-quic-client-server.js
@@ -4,8 +4,8 @@
 // Tests a simple QUIC client/server round-trip
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const { internalBinding } = require('internal/test/binding');
 const {

diff --git a/test/parallel/test-quic-createsocket-err.js b/test/parallel/test-quic-createsocket-err.js
@@ -3,8 +3,8 @@
 // Test QuicSocket constructor option errors
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const assert = require('assert');
 

diff --git a/test/parallel/test-quic-packetloss.js b/test/parallel/test-quic-packetloss.js
@@ -5,8 +5,8 @@
 // retransmission and the requisite data buffering is
 // not yet working correctly
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const Countdown = require('../common/countdown');
 const assert = require('assert');

diff --git a/test/parallel/test-quic-quicsocket.js b/test/parallel/test-quic-quicsocket.js
@@ -4,8 +4,8 @@
 // Test QuicSocket constructor option errors.
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const assert = require('assert');
 

diff --git a/test/parallel/test-quic-serverbusy.js b/test/parallel/test-quic-serverbusy.js
@@ -4,8 +4,8 @@
 // Tests QUIC server busy support
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 // TODO(@jasnell): Marking a server as busy will cause all new
 // connection attempts to fail with a SERVER_BUSY CONNECTION_CLOSE.

diff --git a/test/parallel/test-quic-session-destroy.js b/test/parallel/test-quic-session-destroy.js
@@ -5,8 +5,8 @@
 // abruptly on both ends of the connection.
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const fs = require('fs');
 const fixtures = require('../common/fixtures');

diff --git a/test/parallel/test-quic-simple-client-migrate.js b/test/parallel/test-quic-simple-client-migrate.js
@@ -2,8 +2,8 @@
 'use strict';
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const Countdown = require('../common/countdown');
 const assert = require('assert');

diff --git a/test/parallel/test-quic-stream-close-early.js b/test/parallel/test-quic-stream-close-early.js
@@ -2,8 +2,8 @@
 'use strict';
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const Countdown = require('../common/countdown');
 const assert = require('assert');

diff --git a/test/parallel/test-quic-stream-destroy.js b/test/parallel/test-quic-stream-destroy.js
@@ -5,8 +5,8 @@
 // abruptly on both ends of the connection.
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const assert = require('assert');
 const fs = require('fs');

diff --git a/test/parallel/test-quic-stream-identifiers.js b/test/parallel/test-quic-stream-identifiers.js
@@ -18,8 +18,8 @@
 // +------+----------------------------------+
 
 const common = require('../common');
-if (!common.hasCrypto)
-  common.skip('missing crypto');
+if (!common.hasQuic)
+  common.skip('missing quic');
 
 const Countdown = require('../common/countdown');
 const assert = require('assert');