From f37c8a79bb5577eef365a218213a344f49d6e3aa Mon Sep 17 00:00:00 2001 From: jakecastelli <959672929@qq.com> Date: Wed, 29 May 2024 01:26:14 +0930 Subject: [PATCH 1/2] doc: add note to ninjia build for macOS using -jn flag --- doc/contributing/building-node-with-ninja.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/contributing/building-node-with-ninja.md b/doc/contributing/building-node-with-ninja.md index ddb1fc74d4a00a..b8bc94050cbd3a 100644 --- a/doc/contributing/building-node-with-ninja.md +++ b/doc/contributing/building-node-with-ninja.md @@ -38,6 +38,9 @@ make -j4 # With this flag, Ninja will limit itself to 4 parallel jobs, # regardless of the number of cores on the current machine. ``` +Note: if you are on macOS and use GNU Make version `v3.8.x`, the `-jn` flag +will be ignored, you can either upgrade to v4.x from [Homebrew](https://formulae.brew.sh/formula/make#default) or use `make JOBS=n`. + ## Producing a debug build To create a debug build rather than a release build: From 59e4a34a2e3da2f6052ec76db4397efe0519809c Mon Sep 17 00:00:00 2001 From: jakecastelli <959672929@qq.com> Date: Wed, 29 May 2024 07:43:48 +0930 Subject: [PATCH 2/2] fixup! --- doc/contributing/building-node-with-ninja.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/contributing/building-node-with-ninja.md b/doc/contributing/building-node-with-ninja.md index b8bc94050cbd3a..dbac1c5363444e 100644 --- a/doc/contributing/building-node-with-ninja.md +++ b/doc/contributing/building-node-with-ninja.md @@ -38,8 +38,9 @@ make -j4 # With this flag, Ninja will limit itself to 4 parallel jobs, # regardless of the number of cores on the current machine. ``` -Note: if you are on macOS and use GNU Make version `v3.8.x`, the `-jn` flag -will be ignored, you can either upgrade to v4.x from [Homebrew](https://formulae.brew.sh/formula/make#default) or use `make JOBS=n`. +Note: if you are on macOS and use GNU Make version `3.x`, the `-jn` flag +will not work. You can either upgrade to `v4.x` (e.g. using a package manager +such as [Homebrew](https://formulae.brew.sh/formula/make#default)) or use `make JOBS=n`. ## Producing a debug build