From 672a3af4dd179124aff5d71613c2152753dd6aa1 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Tue, 12 Jan 2021 15:38:00 -0800
Subject: [PATCH 1/3] process: runtime deprecate changing process.config

The fact that `process.config` is mutable has long made it
unreliable when it really should just work. Start the process
of deprecating the ability to change it.

Fixes: https://github.com/nodejs/node/issues/7803
Signed-off-by: James M Snell <jasnell@gmail.com>
---
 doc/api/deprecations.md        | 11 +++++++++++
 lib/internal/bootstrap/node.js | 18 +++++++++++++++++-
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 6aaf1c9fd394d0..be5e57f2260d6f 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -2712,6 +2712,17 @@ Type: Documentation-only.
 
 Prefer [`message.socket`][] over [`message.connection`][].
 
+<a id="DEP0XXX"></a>
+### DEP0XXX: Changing the value of `process.config`
+<!-- YAML
+added: REPLACEME
+-->
+
+The `process.config` property is intended to provide access to configuration
+settings set when the Node.js binary was compiled. However, the property has
+been mutable by user code making it impossible to rely on. The ability to
+change the value has been deprecated and will be disabled in the future.
+
 [Legacy URL API]: url.md#url_legacy_url_api
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 8077c462983154..a4d1c66b55130a 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -59,7 +59,23 @@ process._exiting = false;
 
 // process.config is serialized config.gypi
 const nativeModule = internalBinding('native_module');
-process.config = JSONParse(nativeModule.config);
+
+// TODO(@jasnell): Once this has gone through one full major
+// release cycle, remove the setter and update the getter to
+// either return a read-only object or always return a freshly
+// parsed version of nativeModule.config.
+let processConfig = JSONParse(nativeModule.config);
+ObjectDefineProperty(process, 'config', {
+  enumerable: true,
+  configurable: true,
+  get() { return processConfig; },
+  set: deprecate(
+    (value) => { processConfig = value; },
+    'Setting process.config is deprecated. ' +
+    'In the future the property will be read-only.',
+    'DEP0XXX')
+});
+
 require('internal/worker/js_transferable').setup();
 
 // Bootstrappers for all threads, including worker threads and main thread

From 80bf075a38660c89bf500dd32be22e95d5412379 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Wed, 13 Jan 2021 15:23:44 -0800
Subject: [PATCH 2/3] fixup! process: runtime deprecate changing process.config

---
 doc/api/process.md             |  8 ++++
 lib/internal/bootstrap/node.js | 72 +++++++++++++++++++++++++++++-----
 2 files changed, 71 insertions(+), 9 deletions(-)

diff --git a/doc/api/process.md b/doc/api/process.md
index 5b6e4c5e99fead..dfa6a8eab0f4f2 100644
--- a/doc/api/process.md
+++ b/doc/api/process.md
@@ -759,6 +759,10 @@ This feature is not available in [`Worker`][] threads.
 ## `process.config`
 <!-- YAML
 added: v0.7.7
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/36902
+    description: Modifying process.config has been deprecated.
 -->
 
 * {Object}
@@ -803,6 +807,10 @@ The `process.config` property is **not** read-only and there are existing
 modules in the ecosystem that are known to extend, modify, or entirely replace
 the value of `process.config`.
 
+Modifying the `process.config` property, or any child-property of the
+`process.config` object has been deprecated. The `process.config` will be made
+read-only in a future release.
+
 ## `process.connected`
 <!-- YAML
 added: v0.7.2
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index a4d1c66b55130a..bfd10738865eb4 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -43,7 +43,10 @@ const {
   JSONParse,
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
+  ObjectPreventExtensions,
   ObjectSetPrototypeOf,
+  ReflectGet,
+  ReflectSet,
   SymbolToStringTag,
 } = primordials;
 const config = internalBinding('config');
@@ -61,19 +64,70 @@ process._exiting = false;
 const nativeModule = internalBinding('native_module');
 
 // TODO(@jasnell): Once this has gone through one full major
-// release cycle, remove the setter and update the getter to
-// either return a read-only object or always return a freshly
-// parsed version of nativeModule.config.
-let processConfig = JSONParse(nativeModule.config);
+// release cycle, remove the Proxy and setter and update the
+// getter to either return a read-only object or always return
+// a freshly parsed version of nativeModule.config.
+
+const deprecationHandler = {
+  warned: false,
+  message: 'Setting process.config is deprecated. ' +
+           'In the future the property will be read-only.',
+  code: 'DEP0XXX',
+  maybeWarn() {
+    if (!this.warned) {
+      process.emitWarning(this.message, {
+        type: 'DeprecationWarning',
+        code: this.code
+      });
+      this.warned = true;
+    }
+  },
+
+  defineProperty(target, key, descriptor) {
+    this.maybeWarn();
+    return ObjectDefineProperty(target, key, descriptor);
+  },
+
+  deleteProperty(target, key) {
+    this.maybeWarn();
+    delete target[key];
+  },
+
+  preventExtensions(target) {
+    this.maybeWarn();
+    return ObjectPreventExtensions(target);
+  },
+
+  set(target, key, value) {
+    this.maybeWarn();
+    return ReflectSet(target, key, value);
+  },
+
+  get(target, key, receiver) {
+    const val = ReflectGet(target, key, receiver);
+    if (val != null && typeof val === 'object')
+      return new Proxy(val, deprecationHandler);
+    return val;
+  },
+
+  setPrototypeOf(target, proto) {
+    this.maybeWarn();
+    return ObjectSetPrototypeOf(target, proto);
+  }
+};
+
+let processConfig = new Proxy(
+  JSONParse(nativeModule.config),
+  deprecationHandler);
+
 ObjectDefineProperty(process, 'config', {
   enumerable: true,
   configurable: true,
   get() { return processConfig; },
-  set: deprecate(
-    (value) => { processConfig = value; },
-    'Setting process.config is deprecated. ' +
-    'In the future the property will be read-only.',
-    'DEP0XXX')
+  set(value) {
+    deprecationHandler.maybeWarn();
+    processConfig = value;
+  }
 });
 
 require('internal/worker/js_transferable').setup();

From fdd5f9e132e01b29fa585cad24a0cf62ba47a6f6 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Thu, 14 Jan 2021 09:37:43 -0800
Subject: [PATCH 3/3] [Squash] nits

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 doc/api/deprecations.md | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index be5e57f2260d6f..daac74978761a2 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -2712,12 +2712,16 @@ Type: Documentation-only.
 
 Prefer [`message.socket`][] over [`message.connection`][].
 
-<a id="DEP0XXX"></a>
 ### DEP0XXX: Changing the value of `process.config`
 <!-- YAML
-added: REPLACEME
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/36902
+    description: Runtime deprecation.
 -->
 
+Type: Runtime
+
 The `process.config` property is intended to provide access to configuration
 settings set when the Node.js binary was compiled. However, the property has
 been mutable by user code making it impossible to rely on. The ability to