test: actually test the ttywrap portion of getasyncid #18886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
test
nodejs-github-bot
added
test
BridgeAR
approved these changes
Feb 21, 2018
| @@ -0,0 +1,43 @@ | |||
| 'use strict'; | |||
|
|
|||
| // see also test/sequential/test-async-wrap-getasyncid.js | |||
There was a problem hiding this comment.
This could get outdated easily and I doubt that we actually need that comment. The same applies to the other file accordingly.
There was a problem hiding this comment.
imo, better to have something than nothing
| process.removeAllListeners('uncaughtException'); | ||
| hooks.disable(); | ||
|
|
||
| const obj_keys = Object.keys(providers); |
There was a problem hiding this comment.
Nit: can we go for camelCase instead? :-)
BridgeAR
added
the
author ready
daynin
approved these changes
Feb 21, 2018
Fishrock123
force-pushed
the
actually-test-tty-getasyncid
branch
from
2649289 to
51ea6a9
Compare
Follow-up from nodejs#18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: nodejs#18886 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Fishrock123
force-pushed
the
actually-test-tty-getasyncid
branch
from
51ea6a9 to
af91d94
Compare
|
oops, title was too long. actually landed in 0a26280 |
|
Should this be backported to |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Follow-up from nodejs#18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: nodejs#18886 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Follow-up from nodejs#18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: nodejs#18886 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #18800
Code that tries to exercise tty fds must be placed in
/pseudo-tty/.CI: https://ci.nodejs.org/job/node-test-pull-request/13290/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, tty