doc: add @nodejs/build to onboarding-extras.md #16298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure contributors know to cc @nodejs/build when submitting issues that are build related (in addition to whatever platform are relevant). Ref: #15754 (comment)
cjihrig
approved these changes
Oct 18, 2017
jasnell
approved these changes
Oct 18, 2017
targos
approved these changes
Oct 18, 2017
|
This does not need to wait the 48 hours to land |
refack
approved these changes
Oct 18, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 18, 2017
Make sure contributors know to cc @nodejs/build when submitting issues that are build related (in addition to whatever platform are relevant). PR-URL: #16298 Ref: #15754 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in 20b7805 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
Make sure contributors know to cc @nodejs/build when submitting issues that are build related (in addition to whatever platform are relevant). PR-URL: #16298 Ref: #15754 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
Make sure contributors know to cc @nodejs/build when submitting issues that are build related (in addition to whatever platform are relevant). PR-URL: nodejs/node#16298 Ref: nodejs/node#15754 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Make sure contributors know to cc @nodejs/build when submitting issues that are build related (in addition to whatever platform are relevant). PR-URL: nodejs/node#16298 Ref: nodejs/node#15754 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure contributors know to cc @nodejs/build when submitting issues
that are build related (in addition to whatever platform is relevant).
Ref: #15754 (comment)
Checklist
Affected core subsystem(s)
doc