Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-format to this repo ? #111

Closed
gengjiawen opened this issue Sep 1, 2019 · 4 comments · Fixed by #112
Closed

Add clang-format to this repo ? #111

gengjiawen opened this issue Sep 1, 2019 · 4 comments · Fixed by #112

Comments

@gengjiawen
Copy link
Member

Any thought, I can work on this :)

@mhdawson
Copy link
Member

mhdawson commented Sep 3, 2019

I'm +1 for that. Would be good to make it either consistent with what we do in Node core for formatting or get an agreement that that does not make sense. Long way of saying is that I think it would be good to get some feedback from the Node core C++ developers on the format.

I'm thinking we might want to use the same for node-addon-api as well...

@gengjiawen
Copy link
Member Author

Would be good to make it either consistent with what we do in Node core for formatting

I am planing copy that config.

ong way of saying is that I think it would be good to get some feedback from the Node core C++ developers on the format.

Currently we have no group like @nodejs/cpp . Maybe we can develop a unify cpp style and share it across repos.

@legendecas
Copy link
Member

AFAIK clang-format did not enabled on node core too though .clang-format presents there. Would there be possible of enabling it in node core?

@gengjiawen
Copy link
Member Author

gengjiawen commented Sep 4, 2019

AFAIK clang-format did not enabled on node core too though .clang-format presents there

Nope, it's used. Only test for related change in PR.

Would there be possible of enabling it in node core?

Not likely because of maintain issue. See https://github.com/nodejs/node/issues/25955。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants