Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a new 1.1.0 release with Promises #181

Closed
JamesMGreene opened this issue Nov 5, 2017 · 8 comments
Closed

Publish a new 1.1.0 release with Promises #181

JamesMGreene opened this issue Nov 5, 2017 · 8 comments
Assignees

Comments

@JamesMGreene
Copy link

JamesMGreene commented Nov 5, 2017

Since the Promise implementation was integrated into the current mainline branch via PR #137, I would really like to see a new minor release (v1.1.0) published to NPM. That way, I would be able to change the dependency in one of my N-API example modules to use "node-addon-api": "^1.1.0" instead of "node-addon-api": "rolftimmermans/node-addon-api#promise".

Please consider it. Thanks!

@mhdawson
Copy link
Member

mhdawson commented Nov 7, 2017

We should plan for a new release for this and a few other reasons. I'm out until Nov 16 and can do it when I get back. If its more urgent than that maybe @gabrielschulhof or @jasongin can do a release.

@JamesMGreene
Copy link
Author

I can wait.

@addaleax
Copy link
Member

It might be nice if the process was documented somewhere (or maybe it even is)? Just got caught by node-addon-api@1.0.0 not working on <= Node v6.x

@mhdawson
Copy link
Member

@addaleax which process ? The process for releases ?

@mhdawson
Copy link
Member

My current goal is to do a release Monday Nov 20

@mhdawson mhdawson self-assigned this Nov 17, 2017
@addaleax
Copy link
Member

@mhdawson yes, exactly that :)

@mhdawson
Copy link
Member

Release created/published.

@mhdawson
Copy link
Member

@addaleax it has been pretty add-hoc so far in terms of creating release.

I've created this PR as a first step to document the process: #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants