Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Create ONBOARDING.md #342

Merged
merged 5 commits into from
Aug 8, 2018
Merged

Create ONBOARDING.md #342

merged 5 commits into from
Aug 8, 2018

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Jun 28, 2018

Created a quick initial document for on-boarding new CommComm members. Wanted to throw something together so we can begin discussing and building upon it 👍

@hackygolucky
Copy link
Contributor

I think we should not make assumptions on how versed folks are with 1. Open source practices and 2. Node.js project practices for interacting and administrative duties related to our work, since many of the contributions for our work can live outside of the GitHub project workspace.

To not make assumptions about the familiarity level of people with Node.js project and open source practices, the guide should contain some starter info.

Addresses: #342 (comment)
@keywordnew
Copy link
Contributor

Agreed ^^ Added some material to start.

mhdawson

This comment was marked as off-topic.

@bnb
Copy link
Contributor Author

bnb commented Jul 10, 2018

@chowdhurian @hackygolucky any thoughts on adding a small section about the "consensus seeking" model?

WaleedAshraf

This comment was marked as off-topic.

@keywordnew
Copy link
Contributor

any thoughts on adding a small section about the "consensus seeking" model?

It's the cornerstone of the process here, crucial to buy-in and cooperation. Added!

Bamieh

This comment was marked as off-topic.

@codeekage
Copy link
Contributor

should process around becoming a members get added in this document?

@bnb
Copy link
Contributor Author

bnb commented Jul 26, 2018

@codeekage nope, that belongs in other documentation. The explicit goal of this is to ensure that once we do accept a new member, that we have a laid out process to follow.

@hackygolucky
Copy link
Contributor

This document looks good overall to me. I think a helpful process to call out is the minimum amount of time required for review before we can merge a document. It isn't consistent across the project, so making sure it is known would be nice here.

This whole section is particularly helpful to mention but the hours specifically

Before landing pull requests, sufficient time should be left for input from other Collaborators. Leave at least 48 hours during the week and 72 hours over weekends to account for international time differences and work schedules. Trivial changes (e.g. typos or content changes) may be landed after a shorter delay.
Where there is no disagreement amongst Collaborators, a pull request may be landed given appropriate review. Where there is discussion amongst Collaborators, consensus should be sought if possible. The lack of consensus may indicate the need to elevate discussion to the Community Committee Members for resolution

We can discuss whether it should be consistent across the project in another issue :)

@bnb
Copy link
Contributor Author

bnb commented Aug 8, 2018

Copy/pasted that section @hackygolucky 👍

Going to land this. Let's iterate from here on! 🎊

@bnb bnb merged commit 9464378 into master Aug 8, 2018
@bnb bnb deleted the bnb/create-onboarding branch August 8, 2018 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants