Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS 5 release machine changes #259

Closed
rvagg opened this issue Nov 18, 2015 · 12 comments
Closed

CentOS 5 release machine changes #259

rvagg opened this issue Nov 18, 2015 · 12 comments

Comments

@rvagg
Copy link
Member

rvagg commented Nov 18, 2015

I'm noting this here in an issue because I don't have time to mess with the Ansible configs while I push forward on v0.12 and v0.10 builds.

/etc/sysconfig/jenkins now has this JENKINS_ENV="PRE_1_PATH=/home/iojs/bin:$PATH ARCH=...., and the Jenkins config for the release jobs overwrite PATH if PRE_1_PATH exists and it's a <= v0.12 build.

@rvagg
Copy link
Member Author

rvagg commented Nov 18, 2015

Also, xz is needed on these machines as we discovered today #258

@jbergstroem
Copy link
Member

Is this how we juggle gcc?

@rvagg
Copy link
Member Author

rvagg commented Nov 18, 2015

if [[ "X$PRE_1_PATH" != "X" && $NODE_VERSION =~ ^[0] ]]; then
  export PATH=$PRE_1_PATH
fi

yep

@jbergstroem
Copy link
Member

its almost like we should invert this? i mean, we do the exact same thing to "enable" gcc48.

@rvagg
Copy link
Member Author

rvagg commented Nov 19, 2015

maybe but I've taken the approach that >=v4.x releases are going to be more frequent and will soon be the only releases we're pushing and that <=v0.12 releases are the exception

@jbergstroem
Copy link
Member

Yeah, its just that double negation is kind of awkward. Perhaps create functions available through env that's called gcc48 and gcc41 we call regardless of default?

@rvagg
Copy link
Member Author

rvagg commented Nov 19, 2015

we can easily add POST_1_PATH and do the same there, I'd be happy to do that. Not so sure about using gcc version numbers because they are not consistent across the *nix environments we have.

@jbergstroem
Copy link
Member

@rvagg i didn't see this being used everywhere, just the exceptions which are centos5 and 6(gcc44, right?).

@rvagg
Copy link
Member Author

rvagg commented Nov 22, 2015

mm, in practice it's turned out to be the only thing needed for <=0.12

@jbergstroem
Copy link
Member

How about we do this instead:

if [[ $NODE_VERSION =~ ^[0] ]]; then
  export PATH=${PATH//\/opt\/rh\/devtoolset-2\/root\/usr\/bin:/}
fi

..then remove all the PRE_ variable stuff? I don't see above path changing anytime soon, and if it doesn't match we should be fine anyway.

@rvagg
Copy link
Member Author

rvagg commented Jan 13, 2016

fine, I guess. would be nice to be testing 0.10 and 0.12 with vanilla compilers on wheezy but since I don't think we're doing that then whatever.

@jbergstroem
Copy link
Member

Just implemented this. If things blow up for 0.x you know who to blame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants