-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CentOS 5 release machine changes #259
Comments
Also, |
Is this how we juggle gcc? |
yep |
its almost like we should invert this? i mean, we do the exact same thing to "enable" gcc48. |
maybe but I've taken the approach that >=v4.x releases are going to be more frequent and will soon be the only releases we're pushing and that <=v0.12 releases are the exception |
Yeah, its just that double negation is kind of awkward. Perhaps create functions available through env that's called |
we can easily add |
@rvagg i didn't see this being used everywhere, just the exceptions which are centos5 and 6(gcc44, right?). |
mm, in practice it's turned out to be the only thing needed for <=0.12 |
How about we do this instead: if [[ $NODE_VERSION =~ ^[0] ]]; then
export PATH=${PATH//\/opt\/rh\/devtoolset-2\/root\/usr\/bin:/}
fi ..then remove all the PRE_ variable stuff? I don't see above path changing anytime soon, and if it doesn't match we should be fine anyway. |
fine, I guess. would be nice to be testing 0.10 and 0.12 with vanilla compilers on wheezy but since I don't think we're doing that then whatever. |
Just implemented this. If things blow up for 0.x you know who to blame. |
I'm noting this here in an issue because I don't have time to mess with the Ansible configs while I push forward on v0.12 and v0.10 builds.
/etc/sysconfig/jenkins now has this
JENKINS_ENV="PRE_1_PATH=/home/iojs/bin:$PATH ARCH=....
, and the Jenkins config for the release jobs overwritePATH
ifPRE_1_PATH
exists and it's a <= v0.12 build.The text was updated successfully, but these errors were encountered: