Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function-eslint rule for precise linting #18

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

k-toumura
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

  • The configuration generated by nrlint --init contains "extends": "eslint:recommended". However, this value is not interpreted by ESLint's linter.verify(). This fix expand the setting of the rule corresponding to eslint:recommended as the value of rules.
  • To ensure correct linting of undefined variables etc., function and variable definitions have been included in the string surrounding the code, and comments have been added to prevent these lines from being linted.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.

@knolleary knolleary merged commit 8bb08ac into node-red:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants