Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric pop #65

Closed
tjvr opened this issue Jul 24, 2017 · 4 comments
Closed

Numeric pop #65

tjvr opened this issue Jul 24, 2017 · 4 comments

Comments

@tjvr
Copy link
Collaborator

tjvr commented Jul 24, 2017

...I was convinced that you could pop multiple states, but that doesn't appear to currently be the case.

{match: 'foo', pop: 2}

Is this useful, or should I amend the documentation to make clear you can't?

@nathan
Copy link
Collaborator

nathan commented Jul 24, 2017

I was initially going to allow this when I was implementing states, but I couldn't think of any reasonable use cases.

@tjvr
Copy link
Collaborator Author

tjvr commented Jul 24, 2017

Fixed in 2efc96b (numbers now throw an error, since they're not supported).

@tjvr tjvr closed this as completed Jul 24, 2017
@nathan
Copy link
Collaborator

nathan commented Jul 24, 2017

Perhaps only disallow numbers that aren't 1? Some people like to use {flag: 1} in object literals because it's short and truthy.

@tjvr
Copy link
Collaborator Author

tjvr commented Jul 26, 2017

Okay! 7641fd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants