Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nix versions #41

Merged
merged 2 commits into from
Mar 15, 2024
Merged

chore: update nix versions #41

merged 2 commits into from
Mar 15, 2024

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Mar 10, 2024

@rickynils
Copy link
Contributor

@deemp Thank you for this! I can't wrap my head around why the CI checks fail though. Can you rebase your PR the current master and see if that does the trick?

@deemp
Copy link
Contributor Author

deemp commented Mar 14, 2024

@rickynils, rebased.

Checks failed due to this error https://github.com/nixbuild/nix-quick-install-action/actions/runs/8222697904/job/22660983729#step:4:21

IDK the reason for this error, though.

@rickynils
Copy link
Contributor

@deemp I think I figured it out. When you bumped the nixpkgs revision, nix-2.3.16 also got bumped, to nix-2.3.17. This is fine, but you should add that change to cicd.yml too.

@deemp
Copy link
Contributor Author

deemp commented Mar 14, 2024

@rickynils, bumped

@rickynils rickynils merged commit 896e438 into nixbuild:master Mar 15, 2024
232 checks passed
@rickynils rickynils mentioned this pull request Mar 15, 2024
@deemp
Copy link
Contributor Author

deemp commented Mar 16, 2024

@rickynils, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants