Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api inconsistency Epoll::modify and Epoll::add #2114

Open
dimbleby opened this issue Aug 28, 2023 · 2 comments
Open

api inconsistency Epoll::modify and Epoll::add #2114

dimbleby opened this issue Aug 28, 2023 · 2 comments
Labels
A-ergonomics
Milestone
0.30.0

Comments

@dimbleby
Copy link

dimbleby commented Aug 28, 2023 •
edited
Loading

Epoll::add takes mut event: EpollEvent, whereas Epoll::modify takes event: &mut EpollEvent

seems like an odd difference, am I missing a reason that this is sensible?
@dimbleby dimbleby changed the title api inconsistency epoll::modify and epoll::add api inconsistency Epoll::modify and Epoll::add Aug 28, 2023
@dimbleby
Copy link
Author

#1882, cc @JonathanWoollett-Light

@JonathanWoollett-Light
Copy link
Contributor

JonathanWoollett-Light commented Aug 28, 2023 •
edited
Loading

There is no strong reason.

Epoll::add could takes &mut EpollEvent,it may make sense to make a PR for this.

@SteveLauC SteveLauC added this to the 0.30.0 milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ergonomics
Projects
None yet
Milestone
0.30.0
Development

No branches or pull requests
3 participants
@dimbleby @JonathanWoollett-Light @SteveLauC