feat: add rtl render support #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/render/canvas/canvas-renderer.ts
This was referenced Aug 14, 2021
Closed
Zynton
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 20, 2022
The `html2canvas` library had been downgraded to its version from 2013 because of an issue with RTL rendering (see [1]). In the meantime, the library explicitely introduced RTL rendering support (see [2]). Upgrading the library to its latest (2022) version means a lot of old bugs are fixed. [1] odoo@659e285 [2] niklasvh/html2canvas#2653
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
May 20, 2022
The `html2canvas` library had been downgraded to its version from 2013 because of an issue with RTL rendering (see [1]). In the meantime, the library explicitely introduced RTL rendering support (see [2]). Upgrading the library to its latest (2022) version means a lot of old bugs are fixed. [1] 659e285 [2] niklasvh/html2canvas#2653 closes #91773 Related: odoo/enterprise#27527 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2488
Fixes #2529
Fixes #1460
Fixes #686