No jsx bind #265
Merged
No jsx bind #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| > | ||
| { renderedDay } | ||
| </span> | ||
| </DisabledDay> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
@nikgraf I do not like the idea of extracting a component which just handles event callbacks to get rid of bindings. A component should be a more logical entity and should be able to handle its styling logic and stuff like making dayKey out of date.
If we can do this kind of component it will help us in not just getting rid of bindings but also simplify these complex components.
There was a problem hiding this comment.
I'm open to a PR to simplify the whole structure 😄
I'm not a big fan of having these components just for event handling, but it's the best option I'm aware of to avoid performance issue and therefor more important than not doing it at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.