Support React 0.14 #178
Merged
Support React 0.14 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good ... 👍 |
|
@namuol so cool, thx man. I will test the touch support in the few days and merge it then. |
| @@ -22,7 +22,7 @@ | |||
| "react-component" | |||
| ], | |||
| "peerDependencies": { | |||
| "react": ">=0.13.0" | |||
| "react": ">=0.13.0 <0.15.0 || ^0.14.0-alpha" | |||
There was a problem hiding this comment.
@namuol Hey Louise, @jpuri and I tested it quite intense. Good job. We noticed the 0.14 is already at beta3 and only tested it for this version.
Our idea was to make the version explicit to make sure people don't run into trouble: "react": ">=0.13.0 || ^0.14.0-beta3". Once beta4 is out we can migrate to it and verify there are no breaking changes. Are you using the 0.14.0-alpha anywhere or is it fine like that?
|
Yeah I'm using beta3 and I'd expect most people using 0.14 to be on that version as well. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes allow this to function with React 0.14 (which is in its third beta right now):
Replace
react/lib/ExecutionEnvironmentwithexenvmoduleExecutionEnvironmentis not part of React's public API, and depending on it will break in 0.14, so I replaced it with a small dependency on exenv, which was created for this exact purpose.Conditionally call
initializeTouchEventsThis function has been removed in 0.14, so I only call it if it is available.
I'm not entirely sure if we'll need to make any further changes to ensure touch support behaves the same way with 0.14.
Summary
This PR shouldn't affect anyone currently using 0.13, but will allow for those using 0.14 to use Belle with their project. When 0.14-stable is released, we'll want to make sure touch events behave the same.
Thanks for the awesome components! 🍻