Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox - Incorrect option selected when using filter? #269

Closed
erik-sn opened this issue Mar 23, 2016 · 2 comments
Closed

Combobox - Incorrect option selected when using filter? #269

erik-sn opened this issue Mar 23, 2016 · 2 comments

Comments

@erik-sn
Copy link

erik-sn commented Mar 23, 2016

I am new to React/Belle but am experiencing an issue with the Combobox. I believe this is showing up in the documentation too.

When I set maxOptions and then begin typing into the input to sort through the options, the options are correctly sorted and displayed. However when I click on the option I have filtered down to, the incorrect option is put into the input.

So in the documentation on the currency example, if I begin typing "Egypt" into the box, it correctly sorts and finds the Egypt option: http://i.imgur.com/rrTMlB3.png

However when I click on Egypt, the Australia Dollar shows up in the box: http://i.imgur.com/ynPh6TO.png

It seems like it is simply picking in order - if the filtered option is third on the list, it picks the "Canada Dollar". If Fifth, the "Costa Rica Colon", etc.

I am not sure if I am doing something wrong with this or not, but I am getting the same behavior in my code with different data.

image

image

@nikgraf
Copy link
Owner

nikgraf commented Mar 26, 2016

@kiresuah you are absolutely right! Tomorrow I will have time to fix this and cut a new release right away!

Thanks for reporting

@nikgraf
Copy link
Owner

nikgraf commented Mar 28, 2016

@kiresuah thanks again for reporting. Just release 2.0.5 with a fix.

@nikgraf nikgraf closed this as completed Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants