-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling components instead of custom CSS #179
Comments
Hi @iansinnott Thanks for your suggestion. We were considering pre-defined size-levels for Toggle early on, but dropped the idea due increased complexity. The main idea of Belle components is to allow a lot of styling freedom. By adding a size property people who want to style the Toggle differently might have a hard time doing so. Nevertheless I think we should have done a better job to explain how to style a Toggle. We added an example here: http://nikgraf.github.io/belle/#/component/toggle
If you need help or have a specific size in mind. I'm happy to help. Shouldn't take a lot of time 😄 |
Thanks @nikgraf. Yeah I totally understand if you thought the additional complexity of adding a size prop wasn't worth it. I read through your docs as well, but what made me think of a this feature was that many of the styles are related to eachother to bring the final look together. If all it were possible to pass something like Thanks for the cool lib |
@iansinnott I gave this a bit more thought over the weekend. I totally see the need and tried to come up with a solution that would allow scaling without introducing more complexity. I think a UI configurator where you dynamically could change the styles would be great. In the end you could export the styles. Would you be interested to pair on a simple iteration for the Toggle? Shouldn't take us more than a few hours. |
Absolutely. Let's connect over email and figure out a time that works. I'm at ian@iansinnott.com |
I'm using the
<Toggle />
component and was trying to make it smaller. It seems there is no way to do this other than completely re-styling the element. The components look quite nice but may not be the right size for every UI, so adding a prop to make the element smaller or larger (without changing inline styles) would be great.The text was updated successfully, but these errors were encountered: