Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Critical and Trace log levels #37

Merged
merged 8 commits into from
Oct 29, 2020

Conversation

LayZeeDK
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  1. No Critical log level.
  2. No Trace log level.

Issue Number: N/A

What is the new behavior?

  1. Critical log level added.
  2. Trace log level added.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@LayZeeDK
Copy link
Member Author

Needs more test in the LumberjackService test suite.

@LayZeeDK LayZeeDK marked this pull request as ready for review October 29, 2020 14:24
@LayZeeDK LayZeeDK requested a review from NachoVazquez October 29, 2020 14:25
@NachoVazquez NachoVazquez merged commit 5a18941 into main Oct 29, 2020
@NachoVazquez NachoVazquez deleted the LayZeeDK/feat/additional-log-levels branch October 29, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants