Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require log levels in driver config #36

Merged
merged 6 commits into from
Nov 2, 2020

Conversation

LayZeeDK
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  1. The levels property of a log driver config is optional.
  2. The default log driver config has an undefined levels property.

Issue Number: N/A

What is the new behavior?

  1. The levels property of a log driver config is required.
  2. The default log driver config has Verbose log level.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Both points described in new behavior.

Other information

@LayZeeDK LayZeeDK requested a review from NachoVazquez October 27, 2020 20:48
@LayZeeDK LayZeeDK marked this pull request as draft October 28, 2020 22:29
@LayZeeDK
Copy link
Member Author

The HTTP driver module needs an option to inherit log levels from the root log driver config.

@LayZeeDK
Copy link
Member Author

@NachoVazquez what do you think about commit 7439290?

@LayZeeDK LayZeeDK force-pushed the LayZeeDK/feat/require-log-level-config branch from 7439290 to 69a238c Compare October 29, 2020 21:23
@LayZeeDK LayZeeDK force-pushed the LayZeeDK/feat/require-log-level-config branch 2 times, most recently from 04a4c09 to fa88106 Compare November 1, 2020 22:56
@LayZeeDK
Copy link
Member Author

LayZeeDK commented Nov 1, 2020

Rebased on top of LayZeeDK/test/fix-wallaby-and-driver-tests.

@LayZeeDK LayZeeDK force-pushed the LayZeeDK/feat/require-log-level-config branch from 4109ce6 to b2d8285 Compare November 2, 2020 00:30
@LayZeeDK LayZeeDK marked this pull request as ready for review November 2, 2020 00:37
@LayZeeDK LayZeeDK requested a review from NachoVazquez November 2, 2020 00:37
@NachoVazquez NachoVazquez merged commit e0b5777 into main Nov 2, 2020
@NachoVazquez NachoVazquez deleted the LayZeeDK/feat/require-log-level-config branch November 2, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants