Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Viewer on a public file in a public page #508

Closed
julien-nc opened this issue Jun 3, 2020 · 2 comments
Closed

Open Viewer on a public file in a public page #508

julien-nc opened this issue Jun 3, 2020 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of discussion Being discussed help wanted Extra attention is needed low Low priority pending fix Waiting for a fix on one of our dependencies
Milestone

Comments

@julien-nc
Copy link
Member

Hey!

First of all: It's great to be able to open the viewer for pictures in a public folder page in NC 19. Yay! Thanks a lot.

I'm already using Viewer in standalone mode to display user's pictures in GpxPod. I provide the absolute path and it works great. My problem is I can't find a way to make it happen in GpxPod public pages.

Public pages in GpxPod are using the folder sharing system. They are accessed with the share token as a GET parameter. The page knows the token, the picture files paths (relative to the shared folder path), the file IDs etc...

Is it possible to just call Viewer.open(something); to see a picture? I checked out Viewer sources and it seems the difference is made between public and private pages. Anyway, each time I call Viewer.open() with a relative path or whatever I get prompted for HTTP authentication.

I can generate a valid URL to filesharing/public_preview but it seems useless here.

Any advice?

@julien-nc julien-nc added help wanted Extra attention is needed low Low priority labels Jun 3, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Jun 16, 2020

This is a big limitation indeed.
I also faced this stupid issue and hope to find another way for it. See nextcloud/server#19700 & nextcloud/server#20132

@skjnldsv skjnldsv added the discussion Being discussed label Jun 16, 2020
@skjnldsv skjnldsv changed the title [help] Open Viewer on a public file in a public page Open Viewer on a public file in a public page Aug 24, 2020
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of pending fix Waiting for a fix on one of our dependencies labels Aug 24, 2020
@szaimen
Copy link
Contributor

szaimen commented Sep 27, 2022

done for nc25

@szaimen szaimen closed this as completed Sep 27, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of discussion Being discussed help wanted Extra attention is needed low Low priority pending fix Waiting for a fix on one of our dependencies
Projects
None yet
Development

No branches or pull requests

3 participants