-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewing shared images full sized are cropped #448
Comments
Hey! |
Using this sample (original size): When opening the file as my nextcloud user (authenticated/not as a share): When opening the file from a shared link: Note that the image in a public link is cropped more like landscape (whereas the original is portrait) missing the top parts of the tree in the foreground. The private URL is: The public URL is: Note the The thumbnails in both cases are cropped to squares, but this is likely expected functionality (again tracked in nextcloud/photos#143). |
That is an issue indeed! viewer/src/mixins/PreviewUrl.js Line 69 in ded5b1a
|
Ah, that's why I couldn't find it. I was only grepping this repo. Thanks! |
All good :) You're testing the 18.0.4 beta? Or you're having a test instance with 19? |
This is still running from a daily build (master) that is a few days old. (I'll likely use stable when 19 is released). |
Nice! Thanks for helping on the tests phases! 🚀 |
Of course. Thanks for all your work+help and super speedy fixes! :-) |
Describe the bug
When opening an image that has been shared the full sized version is cropped. I believe it is just missing the preserve aspect ratio option. (This is possibly because the thumbnails do not preserve aspects).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Thumbnails should be cropped (or at least have an option as per nextcloud/photos#143), and are. However when clicking on an image to view we should be able to see the full image.
Screenshots
(Can add along with more details if needed, but hopefully the above is enough).
The text was updated successfully, but these errors were encountered: