Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DB privileges #83

Open
nickvergessen opened this issue Jan 30, 2017 · 2 comments
Open

Check DB privileges #83

nickvergessen opened this issue Jan 30, 2017 · 2 comments
Labels
enhancement feature: upgrade Note: In `server` but called by updater. Also see `feature: installs and updates` in server low robustness 💪 Enhancements (and bugs) related to robustness

Comments

@nickvergessen
Copy link
Member

Original reported by @kehugter in nextcloud/server#2870

I keep my DB user with minimum privileges during normal usage for security reasons. The update using the updater app failed because of missing DROP and INDEX privileges.

Steps to reproduce

  1. Update using the updater app. Finish the first part successfully
  2. Return to the main site to finish updating the database
  3. Update fails because of missing DB privilleges

Expected behaviour

During the sanity check, the user is warned about insufficient DB privileges.

Actual behaviour

No DB privileges check is done, user gets an error message after the Nextcould instance is unusable.

Server configuration

Operating system:
Debian 8.6
Web server:
nginx
Database:
mysql
PHP version:
5.6.29
Nextcloud version: (see Nextcloud admin page)
10.0.2
Updated from an older Nextcloud/ownCloud or fresh install:
Updated from Nextcloud 10.0.1
Where did you install Nextcloud from:
tar archive

@ghost
Copy link

ghost commented Jan 30, 2017

Thanks for migrating, I didn't see this repo.

ALTER could be added to the list of privileges needed specifically for updates.

@joshtrichards joshtrichards added the robustness 💪 Enhancements (and bugs) related to robustness label Sep 24, 2023
@joshtrichards joshtrichards added the feature: upgrade Note: In `server` but called by updater. Also see `feature: installs and updates` in server label Apr 21, 2024
@joshtrichards
Copy link
Member

No DB privileges check is done, user gets an error message after the Nextcould instance is unusable

The Updater just deploys code. This would have to happen either when occ upgrade runs (which is already after the new code is fully deployed). Or something similar to what's proposed here maybe for an early check of DB stuff in the same manner as proposed for apps (versus waiting until code deployment has already happened):

#401 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature: upgrade Note: In `server` but called by updater. Also see `feature: installs and updates` in server low robustness 💪 Enhancements (and bugs) related to robustness
Projects
None yet
Development

No branches or pull requests

2 participants