Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons / Arrows in TOTP #93

Closed
MariusBluem opened this issue Dec 6, 2016 · 6 comments
Closed

Buttons / Arrows in TOTP #93

MariusBluem opened this issue Dec 6, 2016 · 6 comments

Comments

@MariusBluem
Copy link
Member

Since nextcloud/server#1641 brought back the "Log In" button, I think we should overthink the buttons and arrows in TOTP too ... even if I am not a big fan of this decision I am a big fan of uniformity ... So ... Lets remove this arrow from TOTP and replace it with an dedicated button 😉

@jancborchardt @ChristophWurst @nextcloud/designers

@jancborchardt
Copy link
Member

@MariusBluem can you add screenshots for clarification? :)

@ChristophWurst
Copy link
Member

Was changed with #48.

And we use that styling in the backup codes app too, which is part of NC11…

@My1
Copy link
Contributor

My1 commented Dec 18, 2016

uniformity aside, I honestly prefer buttons rather than that arrow, because it's more direct.

@Dennis1993
Copy link

Dennis1993 commented Mar 9, 2017

Where I can see the change?
If I use Microsoft Edge, the arrow to submit the PIN is covered by the X from Edge itself.

edge

The Edge is displaying in each input the X to remove the written text. Maybe we use a button or can remove the X with the following Code:

input[type=text]::-ms-clear {
    display: none;
}

Maybe it is fixed with #48 I don't know :D Then sorry for my post :)

@ChristophWurst
Copy link
Member

Fixed by #149, forgot to close this ticket :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants