Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/6871 smart add to next line #6915

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Feb 24, 2025

📝 Summary

🖼️ Screencasts

🏚️ Before

Bildschirmaufzeichnung.vom.2025-02-24.13-55-48.mp4

🏡 After

Bildschirmaufzeichnung.vom.2025-02-24.13-54-36.mp4

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Max <max@nextcloud.com>
Fixes #6871

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud requested a review from mejo- as a code owner February 24, 2025 12:51
@max-nextcloud max-nextcloud self-assigned this Feb 24, 2025
@max-nextcloud max-nextcloud added design Experience, interaction, interface, … feature: formatting Features related to text formatting and node types 3. to review ux skill: frontend labels Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 37.92%. Comparing base (293ad52) to head (654f290).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/currentLineMenu.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6915      +/-   ##
==========================================
+ Coverage   37.79%   37.92%   +0.12%     
==========================================
  Files         750      735      -15     
  Lines       42720    42577     -143     
  Branches     1273     1258      -15     
==========================================
  Hits        16146    16146              
+ Misses      25952    25824     -128     
+ Partials      622      607      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usability enhancement

@max-nextcloud max-nextcloud merged commit 815f27a into main Feb 24, 2025
63 of 64 checks passed
@max-nextcloud max-nextcloud deleted the fix/6871-smart-add-to-next-line branch February 24, 2025 16:28
@max-nextcloud
Copy link
Collaborator Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review design Experience, interaction, interface, … feature: formatting Features related to text formatting and node types skill: frontend ux
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Smart picker button should open picker in next line
2 participants