Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different focus borders used in menubar #2732

Closed
juliusknorr opened this issue Jul 20, 2022 · 7 comments
Closed

Different focus borders used in menubar #2732

juliusknorr opened this issue Jul 20, 2022 · 7 comments
Labels
1. to develop accessibility bug Something isn't working design Experience, interaction, interface, … high

Comments

@juliusknorr
Copy link
Member

Some of the menu icons use a primary color outline while most of them use the text colored one:

Screen.Recording.2022-07-20.at.08.19.18.mov
@juliusknorr juliusknorr added bug Something isn't working design Experience, interaction, interface, … 1. to develop labels Jul 20, 2022
@susnux
Copy link
Contributor

susnux commented Jul 20, 2022

Or like the emoji picker: No outline.
For me it looks even weirder (Firefox 102):
focused items are filled with text color

@juliusknorr
Copy link
Member Author

The white background should be fixed with latest server nextcloud/server#33246

@susnux
Copy link
Contributor

susnux commented Jul 21, 2022

The white background should be fixed with latest server nextcloud/server#33246

@juliushaertl Only if you have selected the dark theme, when using the system default theme and use a dark color theme, as I do, this still shows the white background.

@juliusknorr
Copy link
Member Author

Weird, I'm using exactly the same constellation. The DarkTheme class is being pulled in depending on the prefers-color-scheme value. Maybe still in the browser cache?

@susnux
Copy link
Contributor

susnux commented Jul 21, 2022

I thought I refreshed the cache... but you are right.

Looks like Buttons use the text color, while ActionButtons (sub menus) use the primary color, and the emoji picker is special.
The emoji picker uses a button, but sets the class to entry-action__button, so there is a clash between the styling rules of Button and ActionButton leading to no outline on focus at all.

@juliusknorr
Copy link
Member Author

Related upstream issue for button component

@juliusknorr
Copy link
Member Author

This is fixed with 26.

@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop accessibility bug Something isn't working design Experience, interaction, interface, … high
Projects
Archived in project
Development

No branches or pull requests

3 participants