Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php mail bug in swift #9730

Closed
guenterpl opened this issue Jun 4, 2018 · 4 comments
Closed

php mail bug in swift #9730

guenterpl opened this issue Jun 4, 2018 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info stale Ticket or PR with no recent activity

Comments

@guenterpl
Copy link

Hi,
I think there is an error in php mail /swift

it call the php mail function with the sender exem. office@xxx.xom

-foffice@xxx.com
instead of statt
-f office@xxx.com

so some mail programm doesnot accept the mail with not valid sender

there is a problem which the $extraparams in swift /transport

best regards
Günter

@MorrisJobke
Copy link
Member

cc @ChristophWurst @rullzer

@MorrisJobke MorrisJobke added bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 4, 2018
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jul 5, 2018
@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Oct 1, 2018
@pawel-slowik
Copy link

I don't think this is a bug, at least not in the Nextcloud server.
The Nextcloud server delegates From: address handling to Swift Mailer:

/** @var Swift_Message */
private $swiftMessage;

public function setFrom(array $addresses): IMessage {
$addresses = $this->convertAddresses($addresses);
$this->swiftMessage->setFrom($addresses);
return $this;
}

I'm guessing that this:

there is a problem which the $extraparams in swift /transport

refers to Swift Mailer source code:
https://github.com/swiftmailer/swiftmailer/blob/181b89f18a90f8925ef805f950d47a7190e9b950/lib/classes/Swift/Transport/SendmailTransport.php#L115-L117
https://github.com/swiftmailer/swiftmailer/blob/181b89f18a90f8925ef805f950d47a7190e9b950/lib/classes/Swift/Transport/MailTransport.php#L28-L29

If there's a problem with that, it should be reported to Swift Mailer.

Most likely, hovewer, there is no bug in Swift Mailer either, because the syntax reported as an error is actually correct.
I.e. this is correct: -foffice@xxx.com.
There should be no space between the -f flag and the email address.
Look it up in man sendmail or on https://linux.die.net/man/8/sendmail.sendmail

I suspect that this is a server configuration issue.

@kesselb
Copy link
Contributor

kesselb commented Aug 17, 2019

Is this still relevant?

@ghost
Copy link

ghost commented Sep 16, 2019

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Sep 16, 2019
@ghost ghost closed this as completed Sep 30, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

7 participants