Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administrative changes should be confirmed by an 2FA token instead of a password by default #7288

Open
j-ed opened this issue Nov 25, 2017 · 10 comments
Labels

Comments

@j-ed
Copy link
Contributor

j-ed commented Nov 25, 2017

Expected behavior

If the twofactor_u2f app has been installed and an external U2F key has been registered all password confirmation dialogs should be replaced by an U2F key confirmation.

Current behavior

If you're going to change a personal setting, a confirmation is usually be requested. Although the twofactor_u2f app has been installed and an external U2F key has been registered, the login password need to be entered manually instead of requesting a confirmation via the available U2F key.

Steps to reproduce

  1. Open the personal settings.
  2. Change e.g. the language setting.
  3. The login password need to be entered to confirm the change.

Environment

Server Configuration

OS: Linux 3.16.47
Web server: Apache2 2.4.29
Database: MariaDB 10.0.32
PHP version: 5.6.29
Nextcloud version: 12.0.3

Client Configuration

Browser: Mozilla Firefox 57.0
Operating system: Windows 7

@MorrisJobke
Copy link
Member

cc @nickvergessen @ChristophWurst

@ChristophWurst
Copy link
Member

This would introduce a hard dependency on the U2F app which now is completely independent.

@MorrisJobke MorrisJobke added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Nov 27, 2017
@j-ed
Copy link
Contributor Author

j-ed commented Nov 27, 2017

@ChristophWurst The twofactor_u2f app already allows to replace or better complete the login process, so it should also be possible to replace the password request if the app has been installed and activated.
Doesn't any kind of hook exist at the relevant place to allow the app to replace the existing confirmation dialog?

@ChristophWurst
Copy link
Member

I'm not aware of any.

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@j-ed
Copy link
Contributor Author

j-ed commented Sep 21, 2018

The issue has still not been fixed in Nextcloud v13.0.6.

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Sep 21, 2018
@MorrisJobke
Copy link
Member

The issue has still not been fixed in Nextcloud v13.0.6.

This is also just an enhancement. Also this ticket is not closed so it is also not fixed in master, nor in 14 and not even in 13. First we need to find time to look into this, then find a technical solution, implement it and then in can be tested.

@j-ed
Copy link
Contributor Author

j-ed commented Sep 30, 2018

@MorrisJobke I understand. Due to the fact that the issue has automatically been classified as stale I worried if this would be the last step before automatically closing the ticket.

@MorrisJobke MorrisJobke changed the title parameter changes should be confirmed by an U2F key instead of a password by default Administrative changes should be confirmed by an 2FA token instead of a password by default Feb 8, 2019
@MorrisJobke
Copy link
Member

Similar request (with TOTP) in #13025

cc @ChristophWurst @nickvergessen

@ChristophWurst
Copy link
Member

Unfortunately the described feature is not really high on our priority list. But this doesn't mean that we don't like the idea or that we are against this feature per se. Quite the opposite! 🙂

There are many way to get new features in Nextcloud:

  1. The easiest and most straight forward way (especially here at Github): pull request.
    Nextcloud is completely Free Software, this means that everyone is welcome to join and to contribute. If you or anyone else want to work on this feature, this would be great! We appreciate every pull request, and we are definitely able to help in case of questions, reviews, etc.

  2. Another option is creating a bounty at Bountysource, although just putting money on an issue doesn't guarantee that someone picks it up (in time). But in general it is a nice way to support the huge Nextcloud community. In case of a Nextcloud GmbH employee picks up the bounty we will give it back to the community by putting the money back on other bounties to make sure all bounties benefit the Nextcloud community.

  3. We have a category for Freelancers in our form. Another option would be to post an offer there and try to find a freelancer who want to work on it.

  4. The most direct way for a company or organization to get the issue addressed is to get a Enterprise Subscription. This includes everything to enable you to run Nextcloud in a productive environment with guaranteed SLA's and more. The Enterprise Subscription also includes optional professional services such as custom development. Feel free to reach out to us. We are happy to explore the possibilities how to make Nextcloud fit your needs.

@skjnldsv
Copy link
Member

Status?

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 20, 2020
@szaimen szaimen removed the needs info label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants