-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to 12.0.3RC2 breaks header bar #6542
Comments
PR: #6112 @Coucouf This looks like you still have the old assets. Could you do a hard refresh in the browser (usually Shift + F5) to verify that the browser doesn't not have cached the old CSS styles. I can't reproduce this in Chrome and Firefox with the RC2. Then the big question is, why it was not cache busted. :/ |
I tracked that down to the index.php/css/core/$hash-server.css using references to a former version : I have a setup like :
the latter being a symlink that I move on upgrade to the latest installed version folder. It looks as if some cache mechanism didn’t notice the symlink changed and kept referencing the (still present) older nextcloud installation folder. Really not straightforward though… |
Worse, putting back nextcloud-12.0.1 in ${ncbasefolder} in the structure above makes the webapp again use the obsolete css… (with the symlink untouched, pointing at the latest nextcloud-12.0.3RC2) I also noticed that some css like $hash-server.css and $hash-share.css are not minified in 12.0.3RC2 whereas a seemingly equivalent setup in 12.0.2 has them minified. |
To be complete in case it can have any impact, I’ve set strong permission on all files in nextcloud-$version so the www user has write access to config/ and its contents only. |
I can confirm that the issue still exists here (with 12.0.3 final) on a similar setup like @Coucouf described. We have Seems like #6587 is related. |
We also got a setup based on symlinks and encounter the described bug while upgrading form 12.0.2 to 12.0.3, moving our old |
Same here:
Strace on apache processes reports the following files to be accessed from the previous version (12.0.2) - maybe this helps to narrow down the cause:
|
I can confirm this as well. Upgraded from 12.0.2 to 12.0.3 and NO symlinks used -> header does not contain items at the right side anymore. They work (menus open), but there's no visible items in header / right. Some other icons look like missing as well (selecting files gives only one icon left side of Tags item) and I think the font has changed. I pretty much ruled out cache issues as well. |
Duplicate of #6028 |
I just upgraded from 12.0.1 to 12.0.3RC2 and it broke the header bar.
Analysing the HTML I noticed that the header changed from an ID in <=12.0.2 :
<div id="header-left">
to a class in 12.0.3RC2 :
<div class="header-left">
Adding back the id="left-header" in core/templates/layout.user.php:46 fixes the issue.
The text was updated successfully, but these errors were encountered: