Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Group) shares should list all users that received the share #6480

Closed
MorrisJobke opened this issue Sep 13, 2017 · 4 comments
Closed

(Group) shares should list all users that received the share #6480

MorrisJobke opened this issue Sep 13, 2017 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: sharing papercut Annoying recurring issue with possibly simple fix.

Comments

@MorrisJobke
Copy link
Member

  • having a group with user A, B, C, D
  • user A shares with this group a folder
  • user B now only sees, that it is shared with that group, but does not know who is in this group and therefore maybe reshares to user C

Related to #3392, #4281 and how shares in circles are handled.

cc @nextcloud/designers for nice ideas how to show this
cc @daita for circles
cc @nextcloud/sharing for the general sharing stuff

@MorrisJobke MorrisJobke added design Design, UI, UX, etc. enhancement feature: sharing papercut Annoying recurring issue with possibly simple fix. labels Sep 13, 2017
@ArtificialOwl
Copy link
Member

I don't know if we should display the memberlist, but maybe (if it is not already the case) check if the file is already shared in any way (circles, groups, ...) to C (and display a message that the file is already shared). Like browsing all provider->getSharedWith() (not sure at 100% on this call).

Now, what is gonna happen if A share a folder to the group and B shares a single file from this folder to C ?

@rullzer
Copy link
Member

rullzer commented Sep 13, 2017

Listing all members is a big no go. This will explode hard. Assume an LDAP group with 10k members. That is not going to be of any use.

What we should do (what is still on the TODO somewhere) is do more grouping of shares. So that the receiving end doesn't care.

Then we can also lift this silly restrictiong that you can't share to somebody that already got the share. Since it will be grouped anyway.

@jancborchardt
Copy link
Member

Besides @rullzer’s point what we could do is show a tooltip with the members, or at least the first 10 »and 25 more«. That’s similar to how Github does it for teams when you hover them (see above in @MorrisJobke’s original issue when you hover the designers group) and also how we did it in the video calls app navigation.

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@MorrisJobke MorrisJobke changed the title Group shares should list all members that received the share (Group) shares should list all members that received the share Jul 24, 2018
@MorrisJobke MorrisJobke changed the title (Group) shares should list all members that received the share (Group) shares should list all users that received the share Jul 24, 2018
This was referenced Oct 2, 2018
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019
@skjnldsv
Copy link
Member

I guess fixed with 18 righty?
With the new inherited shares :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: sharing papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

6 participants