-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Group) shares should list all users that received the share #6480
Comments
I don't know if we should display the memberlist, but maybe (if it is not already the case) check if the file is already shared in any way (circles, groups, ...) to C (and display a message that the file is already shared). Like browsing all provider->getSharedWith() (not sure at 100% on this call). Now, what is gonna happen if A share a folder to the group and B shares a single file from this folder to C ? |
Listing all members is a big no go. This will explode hard. Assume an LDAP group with 10k members. That is not going to be of any use. What we should do (what is still on the TODO somewhere) is do more grouping of shares. So that the receiving end doesn't care. Then we can also lift this silly restrictiong that you can't share to somebody that already got the share. Since it will be grouped anyway. |
Besides @rullzer’s point what we could do is show a tooltip with the members, or at least the first 10 »and 25 more«. That’s similar to how Github does it for teams when you hover them (see above in @MorrisJobke’s original issue when you hover the designers group) and also how we did it in the video calls app navigation. |
I guess fixed with 18 righty? |
Related to #3392, #4281 and how shares in circles are handled.
cc @nextcloud/designers for nice ideas how to show this
cc @daita for circles
cc @nextcloud/sharing for the general sharing stuff
The text was updated successfully, but these errors were encountered: