Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled appstore in config.php still access the store #2959

Closed
Gomez opened this issue Jan 5, 2017 · 3 comments · Fixed by #3287
Closed

Disabled appstore in config.php still access the store #2959

Gomez opened this issue Jan 5, 2017 · 3 comments · Fixed by #3287
Labels
3. to review Waiting for reviews bug

Comments

@Gomez
Copy link
Member

Gomez commented Jan 5, 2017

Steps to reproduce

  1. Add 'appstoreenabled' => false to config.php
  2. Access https://cloudurl.com/settings/apps

Expected behaviour

Only apps that exits on the filesystem should be installable. No other category than "Enabled" and "Not enabled" should be shown. (Like in Nextcloud 10)

Actual behaviour

Many categories are shown like Files, Multimedia ...
All Apps from the store are shown.

Server configuration

Nextcloud version: (see Nextcloud admin page)
Version 11.0.0 (git)

Updated from an older Nextcloud/ownCloud or fresh install:
Fresh

Where did you install Nextcloud from:
GIT

@Gomez Gomez added the bug label Jan 5, 2017
@Gomez
Copy link
Member Author

Gomez commented Jan 5, 2017

Related #2701

@Gomez
Copy link
Member Author

Gomez commented Jan 14, 2017

Thanks to @nickvergessen just a "return [];" in https://github.com/nextcloud/server/blob/master/lib/private/App/AppStore/Fetcher/Fetcher.php#L97 solves it.

I will create a proper PR.

@MorrisJobke
Copy link
Member

Fix is in #3287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants