Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration path for legacy encrypted files #27501

Open
juliusknorr opened this issue Jun 14, 2021 · 3 comments
Open

Migration path for legacy encrypted files #27501

juliusknorr opened this issue Jun 14, 2021 · 3 comments
Labels

Comments

@juliusknorr
Copy link
Member

With #22218 we added the ability to disable decryption of files using the legacy cipher. While it allows admins to scan for files where the header is missing, we currently lack a migration path to fully drop the old code path at some point.

For master key encryption we could just re-encrypt those files in an occ command, though for setups where there is no master key we cannot do that so that would basically mean we never can drop it without the possibility to make files inaccessible. Though a migration command for master key setups might still make sense.

@sarunasb
Copy link

sarunasb commented Sep 27, 2021

For master key encryption we could just re-encrypt those files in an occ command,

By ‘re-encrypt’ do you mean occ encryption:encrypt-all? After setting 'encryption.legacy_format_support' => false?

Thanks...

@niclashoyer
Copy link

Just ran into this today after a Nextcloud upgrade. Please provide a way forward without a complete reinstallation. I'm currently stuck with legacy encryption as I don't know what to do. The occ encryption:scan:legacy-format commands says that it is ok to turn legacy encryption off, but afterwards I get #8546 and can't access my files, so I had to turn it back on.

Even if there is no feasible solution, please document that and make it clear, so that we aren't stuck in some legacy fashion and reinstall right away.

@whinis
Copy link

whinis commented Jan 20, 2023

I just did a fair amount of searching on github and it lead me to error with #33098 . It seems if I set encryption.legacy_format_support to false then I can access all my files fine but any new files uploaded are still in the old format and give me an invalid signature unless I access them first logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants