-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to open status selection when scrolled down #22606
Comments
See my comment in nextcloud-libraries/nextcloud-vue#1384 (comment). From my side there will be no solution to fix this other than setting |
So, how do we proceed here? Globally changing the CSS in server obviously is no solution as it breaks some apps at the moment. However, I think we still need to fix this issue, also for Nextcloud 20. As only apps which use the default layout are affected by this, it might be a solution to fix this on a per app basis for now. I know this is more work, and not the ideal solution for something that should just work, but the advantage is we could check per app if something breaks. Apps currently affected by this problem are (list is not exhaustive):
For all these apps adding body {
min-height: 100%;
height: auto; /* necessary to overwrite the server css rule */
} like I did for Tasks in nextcloud/tasks#1224 fixes the issue and I couldn't see any problems (but this sure needs more testing). Later on we could adjust apps which currently break with this style (e.g. Talk) to anyway work properly and move this CSS rule to server. @nextcloud/vuejs What do you think? |
I agree that for 20 it makes most sense to fix this in the individual apps and then we can make the full height body a default on server master as a next step so it is in as a change early for 21. From a standardization perspective apps like talk and deck which have different scroll area can then apply a workaround for their custom implementation. |
For reference, after discussion meetings, we decided to move the statuses Online/Away/Dnd/Invisible into the modal and have a click on "Set status" open the modal directly. (The biggest reason being so that the "Status message" part is more obvious and not buried so deeply.) So no dropdown anymore, and the problem will be gone. Ref @rullzer @nickvergessen @juliushaertl |
Will be fixed through pull request #23130 |
Also, the status select popover moves out of the viewport when scrolling and flutters while scrolling. See here:
This is due to the
boundaries-element
beingbody
which moves out of the viewport. The flutter is due to the container beingbody
as well, which moves. See nextcloud-libraries/nextcloud-vue#1384 for details.Server version: latest master.
The text was updated successfully, but these errors were encountered: